tcg: Replace asserts on tcg_jmp_insn_offset
Test TCG_TARGET_HAS_direct_jump instead of testing an implementation pointer. Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
parent
1ce41e0443
commit
7f83167c61
@ -1918,7 +1918,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
|
|||||||
|
|
||||||
switch (opc) {
|
switch (opc) {
|
||||||
case INDEX_op_goto_tb:
|
case INDEX_op_goto_tb:
|
||||||
tcg_debug_assert(s->tb_jmp_insn_offset != NULL);
|
qemu_build_assert(TCG_TARGET_HAS_direct_jump);
|
||||||
/*
|
/*
|
||||||
* Ensure that ADRP+ADD are 8-byte aligned so that an atomic
|
* Ensure that ADRP+ADD are 8-byte aligned so that an atomic
|
||||||
* write can be used to patch the target address.
|
* write can be used to patch the target address.
|
||||||
|
@ -1953,7 +1953,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
|
|||||||
intptr_t ptr, dif, dil;
|
intptr_t ptr, dif, dil;
|
||||||
TCGReg base = TCG_REG_PC;
|
TCGReg base = TCG_REG_PC;
|
||||||
|
|
||||||
tcg_debug_assert(s->tb_jmp_insn_offset == 0);
|
qemu_build_assert(!TCG_TARGET_HAS_direct_jump);
|
||||||
ptr = (intptr_t)tcg_splitwx_to_rx(s->tb_jmp_target_addr + args[0]);
|
ptr = (intptr_t)tcg_splitwx_to_rx(s->tb_jmp_target_addr + args[0]);
|
||||||
dif = tcg_pcrel_diff(s, (void *)ptr) - 8;
|
dif = tcg_pcrel_diff(s, (void *)ptr) - 8;
|
||||||
dil = sextract32(dif, 0, 12);
|
dil = sextract32(dif, 0, 12);
|
||||||
|
@ -1090,7 +1090,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
|
|||||||
|
|
||||||
switch (opc) {
|
switch (opc) {
|
||||||
case INDEX_op_goto_tb:
|
case INDEX_op_goto_tb:
|
||||||
tcg_debug_assert(s->tb_jmp_insn_offset != NULL);
|
qemu_build_assert(TCG_TARGET_HAS_direct_jump);
|
||||||
/*
|
/*
|
||||||
* Ensure that patch area is 8-byte aligned so that an
|
* Ensure that patch area is 8-byte aligned so that an
|
||||||
* atomic write can be used to patch the target address.
|
* atomic write can be used to patch the target address.
|
||||||
|
@ -1987,7 +1987,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
|
|||||||
switch (opc) {
|
switch (opc) {
|
||||||
case INDEX_op_goto_tb:
|
case INDEX_op_goto_tb:
|
||||||
/* indirect jump method */
|
/* indirect jump method */
|
||||||
tcg_debug_assert(s->tb_jmp_insn_offset == 0);
|
qemu_build_assert(!TCG_TARGET_HAS_direct_jump);
|
||||||
tcg_out_ld(s, TCG_TYPE_PTR, TCG_TMP0, TCG_REG_ZERO,
|
tcg_out_ld(s, TCG_TYPE_PTR, TCG_TMP0, TCG_REG_ZERO,
|
||||||
(uintptr_t)(s->tb_jmp_target_addr + a0));
|
(uintptr_t)(s->tb_jmp_target_addr + a0));
|
||||||
tcg_out_opc_reg(s, OPC_JR, 0, TCG_TMP0, 0);
|
tcg_out_opc_reg(s, OPC_JR, 0, TCG_TMP0, 0);
|
||||||
|
@ -1311,7 +1311,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
|
|||||||
|
|
||||||
switch (opc) {
|
switch (opc) {
|
||||||
case INDEX_op_goto_tb:
|
case INDEX_op_goto_tb:
|
||||||
assert(s->tb_jmp_insn_offset == 0);
|
qemu_build_assert(!TCG_TARGET_HAS_direct_jump);
|
||||||
/* indirect jump method */
|
/* indirect jump method */
|
||||||
tcg_out_ld(s, TCG_TYPE_PTR, TCG_REG_TMP0, TCG_REG_ZERO,
|
tcg_out_ld(s, TCG_TYPE_PTR, TCG_REG_TMP0, TCG_REG_ZERO,
|
||||||
(uintptr_t)(s->tb_jmp_target_addr + a0));
|
(uintptr_t)(s->tb_jmp_target_addr + a0));
|
||||||
|
@ -603,7 +603,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
|
|||||||
|
|
||||||
switch (opc) {
|
switch (opc) {
|
||||||
case INDEX_op_goto_tb:
|
case INDEX_op_goto_tb:
|
||||||
tcg_debug_assert(s->tb_jmp_insn_offset == 0);
|
qemu_build_assert(!TCG_TARGET_HAS_direct_jump);
|
||||||
/* indirect jump method. */
|
/* indirect jump method. */
|
||||||
tcg_out_op_p(s, opc, s->tb_jmp_target_addr + args[0]);
|
tcg_out_op_p(s, opc, s->tb_jmp_target_addr + args[0]);
|
||||||
set_jmp_reset_offset(s, args[0]);
|
set_jmp_reset_offset(s, args[0]);
|
||||||
|
Loading…
x
Reference in New Issue
Block a user