yannick.naumann/RT-Task-Generator-QEMU
1
0
Fork 0
forked from alwin.berger/FRET-qemu
Code Pull Requests Activity

char-stdio: Fix QMP default for 'signal'

Browse Source 
Commit 02c4bdf1 tried to make signal=on the default for stdio chardevs
except for '-serial mon:stdio', but it forgot about QMP and accidentally
switched the QMP default from true (except for -nographic) to false
(always). The documentation was kept unchanged and still describes the
opposite of the old behaviour (which is an even older documentation
bug).

Fix all of this by making signal=true the default in ChardevStdio and
documenting it as such.

Fixes: 02c4bdf1d2ca8c02a9bae16398f260b5c08d08bf
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20201023101222.250147-2-kwolf@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Kevin Wolf 2020-10-23 12:12:17 +02:00
parent bce36c6c54
commit 6deb20f668
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
chardev/char-stdio.c
View File

@ -112,9 +112,7 @@ static void qemu_chr_open_stdio(Chardev *chr,
qemu_chr_open_fd(chr, 0, 1); qemu_chr_open_fd(chr, 0, 1);
if (opts->has_signal) { stdio_allow_signal = !opts->has_signal || opts->signal;
stdio_allow_signal = opts->signal;
}
qemu_chr_set_echo_stdio(chr, false); qemu_chr_set_echo_stdio(chr, false);
} }
#endif #endif

3
qapi/char.json
View File

@ -321,8 +321,7 @@
# Configuration info for stdio chardevs. # Configuration info for stdio chardevs.
# #
# @signal: Allow signals (such as SIGINT triggered by ^C) # @signal: Allow signals (such as SIGINT triggered by ^C)
# be delivered to qemu. Default: true in -nographic mode, # be delivered to qemu. Default: true.
# false otherwise.
# #
# Since: 1.5 # Since: 1.5
## ##