hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sh: stacktrace: Remove stacktrace_ops.stack()

Browse Source 
The SH implementation never called stacktrace_ops.stack().
Presumably this was copied from the x86 implementation.

Hence remove the method, and all implementations (most of them are
dummies).

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rich Felker <dalias@libc.org>
This commit is contained in:
Geert Uytterhoeven 2020-06-18 09:59:37 +02:00 committed by Rich Felker
parent eac1a48817
commit c0735ae9a0
5 changed files with 0 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/sh/include/asm/stacktrace.h
View File

@ -12,8 +12,6 @@
struct stacktrace_ops { struct stacktrace_ops {
void (*address)(void *data, unsigned long address, int reliable); void (*address)(void *data, unsigned long address, int reliable);
/* On negative return stop dumping */
int (*stack)(void *data, char *name);
}; };
void dump_trace(struct task_struct *tsk, struct pt_regs *regs, void dump_trace(struct task_struct *tsk, struct pt_regs *regs,

7
arch/sh/kernel/dumpstack.c
View File

@ -107,12 +107,6 @@ stack_reader_dump(struct task_struct *task, struct pt_regs *regs,
} }
} }
static int print_trace_stack(void *data, char *name)
{
printk("%s <%s> ", (char *)data, name);
return 0;
}
/* /*
* Print one address/symbol entries per line. * Print one address/symbol entries per line.
*/ */
@ -123,7 +117,6 @@ static void print_trace_address(void *data, unsigned long addr, int reliable)
} }
static const struct stacktrace_ops print_trace_ops = { static const struct stacktrace_ops print_trace_ops = {
.stack = print_trace_stack,
.address = print_trace_address, .address = print_trace_address,
}; };

6
arch/sh/kernel/perf_callchain.c
View File

@ -11,11 +11,6 @@
#include <asm/unwinder.h> #include <asm/unwinder.h>
#include <asm/ptrace.h> #include <asm/ptrace.h>
static int callchain_stack(void *data, char *name)
{
return 0;
}
static void callchain_address(void *data, unsigned long addr, int reliable) static void callchain_address(void *data, unsigned long addr, int reliable)
{ {
struct perf_callchain_entry_ctx *entry = data; struct perf_callchain_entry_ctx *entry = data;
@ -25,7 +20,6 @@ static void callchain_address(void *data, unsigned long addr, int reliable)
} }
static const struct stacktrace_ops callchain_ops = { static const struct stacktrace_ops callchain_ops = {
.stack = callchain_stack,
.address = callchain_address, .address = callchain_address,
}; };

7
arch/sh/kernel/stacktrace.c
View File

@ -15,11 +15,6 @@
#include <asm/ptrace.h> #include <asm/ptrace.h>
#include <asm/stacktrace.h> #include <asm/stacktrace.h>
static int save_stack_stack(void *data, char *name)
{
return 0;
}
/* /*
* Save stack-backtrace addresses into a stack_trace buffer. * Save stack-backtrace addresses into a stack_trace buffer.
*/ */
@ -40,7 +35,6 @@ static void save_stack_address(void *data, unsigned long addr, int reliable)
} }
static const struct stacktrace_ops save_stack_ops = { static const struct stacktrace_ops save_stack_ops = {
.stack = save_stack_stack,
.address = save_stack_address, .address = save_stack_address,
}; };
@ -73,7 +67,6 @@ save_stack_address_nosched(void *data, unsigned long addr, int reliable)
} }
static const struct stacktrace_ops save_stack_ops_nosched = { static const struct stacktrace_ops save_stack_ops_nosched = {
.stack = save_stack_stack,
.address = save_stack_address_nosched, .address = save_stack_address_nosched,
}; };

7
arch/sh/oprofile/backtrace.c
View File

@ -19,12 +19,6 @@
#include <asm/sections.h> #include <asm/sections.h>
#include <asm/stacktrace.h> #include <asm/stacktrace.h>
static int backtrace_stack(void *data, char *name)
{
/* Yes, we want all stacks */
return 0;
}
static void backtrace_address(void *data, unsigned long addr, int reliable) static void backtrace_address(void *data, unsigned long addr, int reliable)
{ {
unsigned int *depth = data; unsigned int *depth = data;
@ -34,7 +28,6 @@ static void backtrace_address(void *data, unsigned long addr, int reliable)
} }
static struct stacktrace_ops backtrace_ops = { static struct stacktrace_ops backtrace_ops = {
.stack = backtrace_stack,
.address = backtrace_address, .address = backtrace_address,
}; };