coccinelle: api: extend memdup_user rule with vmemdup_user()
Add vmemdup_user() transformations to the memdup_user.cocci rule.
Commit 50fd2f298b
("new primitive: vmemdup_user()") introduced
vmemdup_user(). The function uses kvmalloc with GPF_USER flag.
Signed-off-by: Denis Efremov <efremov@linux.com>
This commit is contained in:
parent
547ade42ce
commit
9c568dbd67
@ -39,6 +39,28 @@ identifier l1,l2;
|
|||||||
- ...+>
|
- ...+>
|
||||||
- }
|
- }
|
||||||
|
|
||||||
|
@depends on patch@
|
||||||
|
expression from,to,size;
|
||||||
|
identifier l1,l2;
|
||||||
|
@@
|
||||||
|
|
||||||
|
- to = \(kvmalloc\|kvzalloc\)(size,\(GFP_KERNEL\|GFP_USER\));
|
||||||
|
+ to = vmemdup_user(from,size);
|
||||||
|
if (
|
||||||
|
- to==NULL
|
||||||
|
+ IS_ERR(to)
|
||||||
|
|| ...) {
|
||||||
|
<+... when != goto l1;
|
||||||
|
- -ENOMEM
|
||||||
|
+ PTR_ERR(to)
|
||||||
|
...+>
|
||||||
|
}
|
||||||
|
- if (copy_from_user(to, from, size) != 0) {
|
||||||
|
- <+... when != goto l2;
|
||||||
|
- -EFAULT
|
||||||
|
- ...+>
|
||||||
|
- }
|
||||||
|
|
||||||
@r depends on !patch@
|
@r depends on !patch@
|
||||||
expression from,to,size;
|
expression from,to,size;
|
||||||
position p;
|
position p;
|
||||||
@ -52,6 +74,17 @@ statement S1,S2;
|
|||||||
if (copy_from_user(to, from, size) != 0)
|
if (copy_from_user(to, from, size) != 0)
|
||||||
S2
|
S2
|
||||||
|
|
||||||
|
@rv depends on !patch@
|
||||||
|
expression from,to,size;
|
||||||
|
position p;
|
||||||
|
statement S1,S2;
|
||||||
|
@@
|
||||||
|
|
||||||
|
* to = \(kvmalloc@p\|kvzalloc@p\)(size,\(GFP_KERNEL\|GFP_USER\));
|
||||||
|
if (to==NULL || ...) S1
|
||||||
|
if (copy_from_user(to, from, size) != 0)
|
||||||
|
S2
|
||||||
|
|
||||||
@script:python depends on org@
|
@script:python depends on org@
|
||||||
p << r.p;
|
p << r.p;
|
||||||
@@
|
@@
|
||||||
@ -63,3 +96,15 @@ p << r.p;
|
|||||||
@@
|
@@
|
||||||
|
|
||||||
coccilib.report.print_report(p[0], "WARNING opportunity for memdup_user")
|
coccilib.report.print_report(p[0], "WARNING opportunity for memdup_user")
|
||||||
|
|
||||||
|
@script:python depends on org@
|
||||||
|
p << rv.p;
|
||||||
|
@@
|
||||||
|
|
||||||
|
coccilib.org.print_todo(p[0], "WARNING opportunity for vmemdup_user")
|
||||||
|
|
||||||
|
@script:python depends on report@
|
||||||
|
p << rv.p;
|
||||||
|
@@
|
||||||
|
|
||||||
|
coccilib.report.print_report(p[0], "WARNING opportunity for vmemdup_user")
|
||||||
|
Loading…
Reference in New Issue
Block a user