hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spi: cadence-quadspi: add missing of_node_put

Browse Source 
Fix OF node leaks by calling of_node_put in
for_each_available_child_of_node when the cycle returns.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
Link: https://lore.kernel.org/r/20210215110425.1012-1-angkery@163.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Junlin Yang 2021-02-15 19:04:25 +08:00 committed by Mark Brown
parent 120a9e8155
commit 87d62d8fa6
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/spi/spi-cadence-quadspi.c
View File

@ -1389,11 +1389,13 @@ static int cqspi_setup_flash(struct cqspi_st *cqspi)
ret = of_property_read_u32(np, "reg", &cs); ret = of_property_read_u32(np, "reg", &cs);
if (ret) { if (ret) {
dev_err(dev, "Couldn't determine chip select.\n"); dev_err(dev, "Couldn't determine chip select.\n");
of_node_put(np);
return ret; return ret;
} }
if (cs >= CQSPI_MAX_CHIPSELECT) { if (cs >= CQSPI_MAX_CHIPSELECT) {
dev_err(dev, "Chip select %d out of range.\n", cs); dev_err(dev, "Chip select %d out of range.\n", cs);
of_node_put(np);
return -EINVAL; return -EINVAL;
} }
@ -1402,9 +1404,11 @@ static int cqspi_setup_flash(struct cqspi_st *cqspi)
f_pdata->cs = cs; f_pdata->cs = cs;
ret = cqspi_of_get_flash_pdata(pdev, f_pdata, np); ret = cqspi_of_get_flash_pdata(pdev, f_pdata, np);
if (ret) if (ret) {
of_node_put(np);
return ret; return ret;
} }
}
return 0; return 0;
} }