hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: mdiobus: fix an OF node reference leak

Browse Source 
[ Upstream commit 572af9f284669d31d9175122bbef9bc62cea8ded ]

fwnode_find_mii_timestamper() calls of_parse_phandle_with_fixed_args()
but does not decrement the refcount of the obtained OF node. Add an
of_node_put() call before returning from the function.

This bug was detected by an experimental static analysis tool that I am
developing.

Fixes: bc1bee3b87 ("net: mdiobus: Introduce fwnode_mdiobus_register_phy()")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20241218035106.1436405-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Joe Hattori 2024-12-18 12:51:06 +09:00 committed by Greg Kroah-Hartman
parent 7134f6372c
commit 26429dc63e
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/net/mdio/fwnode_mdio.c
View File

@ -38,6 +38,7 @@ fwnode_find_pse_control(struct fwnode_handle *fwnode)
static struct mii_timestamper * static struct mii_timestamper *
fwnode_find_mii_timestamper(struct fwnode_handle *fwnode) fwnode_find_mii_timestamper(struct fwnode_handle *fwnode)
{ {
struct mii_timestamper *mii_ts;
struct of_phandle_args arg; struct of_phandle_args arg;
int err; int err;
@ -51,10 +52,16 @@ fwnode_find_mii_timestamper(struct fwnode_handle *fwnode)
else if (err) else if (err)
return ERR_PTR(err); return ERR_PTR(err);
if (arg.args_count != 1) if (arg.args_count != 1) {
return ERR_PTR(-EINVAL); mii_ts = ERR_PTR(-EINVAL);
goto put_node;
}
return register_mii_timestamper(arg.np, arg.args[0]); mii_ts = register_mii_timestamper(arg.np, arg.args[0]);
put_node:
of_node_put(arg.np);
return mii_ts;
} }
int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio, int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio,