david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

egl-helpers: fix possible resource leak

Browse Source 
CID 1352419, using g_strdup_printf instead of asprintf.

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1463047028-123868-2-git-send-email-arei.gonglei@huawei.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Gonglei 2016-05-12 17:57:07 +08:00 committed by Gerd Hoffmann
parent 42ddb8aa7c
commit f454f49c42
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ui/egl-helpers.c
View File

@ -49,18 +49,15 @@ int qemu_egl_rendernode_open(void)
continue; continue;
} }
r = asprintf(&p, "/dev/dri/%s", e->d_name); p = g_strdup_printf("/dev/dri/%s", e->d_name);
if (r < 0) {
return -1;
}
r = open(p, O_RDWR | O_CLOEXEC | O_NOCTTY | O_NONBLOCK); r = open(p, O_RDWR | O_CLOEXEC | O_NOCTTY | O_NONBLOCK);
if (r < 0) { if (r < 0) {
free(p); g_free(p);
continue; continue;
} }
fd = r; fd = r;
free(p); g_free(p);
break; break;
} }