david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

check for successful chdir()

Browse Source
This commit is contained in:
Steffen Schulz 2022-11-04 16:29:41 -07:00 committed by Sergej Schumilo
parent 8a88edc2a1
commit f1bb7b29c4
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
nyx/sharedir.c
View File

@ -4,6 +4,7 @@
#include <dirent.h> #include <dirent.h>
#include <stdbool.h> #include <stdbool.h>
#include <stdio.h> #include <stdio.h>
#include <string.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/types.h> #include <sys/types.h>
#include <unistd.h> #include <unistd.h>
@ -55,9 +56,12 @@ static char *sharedir_scan(sharedir_t *self, const char *file)
* Agent is not under our control, but lets roughly constrain * Agent is not under our control, but lets roughly constrain
* it to anything stored in or linked from sharedir * it to anything stored in or linked from sharedir
*/ */
chdir(self->dir); if (0 != chdir(self->dir)) {
char *real_path = realpath(file, NULL); nyx_error("Failed to chdir to sharedir: %s", strerror(errno));
return NULL;
}
char *real_path = realpath(file, NULL);
if (file[0] != '/' && !strstr(file, "/../") && real_path && file_exits(real_path)) if (file[0] != '/' && !strstr(file, "/../") && real_path && file_exits(real_path))
{ {
return real_path; return real_path;