david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vdi: change goto to loop

Browse Source 
Finally reindent all code and change goto statements to a loop.

Acked-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Paolo Bonzini 2012-03-19 18:07:51 +01:00 committed by Kevin Wolf
parent 4eea78e634
commit eb9566d13e
1 changed files with 69 additions and 74 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

143
block/vdi.c
View File

@ -474,41 +474,38 @@ static int vdi_co_read(BlockDriverState *bs,
uint32_t block_index; uint32_t block_index;
uint32_t sector_in_block; uint32_t sector_in_block;
uint32_t n_sectors; uint32_t n_sectors;
int ret; int ret = 0;
logout("\n"); logout("\n");
restart: while (ret >= 0 && nb_sectors > 0) {
block_index = sector_num / s->block_sectors; block_index = sector_num / s->block_sectors;
sector_in_block = sector_num % s->block_sectors; sector_in_block = sector_num % s->block_sectors;
n_sectors = s->block_sectors - sector_in_block; n_sectors = s->block_sectors - sector_in_block;
if (n_sectors > nb_sectors) { if (n_sectors > nb_sectors) {
n_sectors = nb_sectors; n_sectors = nb_sectors;
} }
logout("will read %u sectors starting at sector %" PRIu64 "\n", logout("will read %u sectors starting at sector %" PRIu64 "\n",
n_sectors, sector_num); n_sectors, sector_num);
/* prepare next AIO request */ /* prepare next AIO request */
bmap_entry = le32_to_cpu(s->bmap[block_index]); bmap_entry = le32_to_cpu(s->bmap[block_index]);
if (!VDI_IS_ALLOCATED(bmap_entry)) { if (!VDI_IS_ALLOCATED(bmap_entry)) {
/* Block not allocated, return zeros, no need to wait. */ /* Block not allocated, return zeros, no need to wait. */
memset(buf, 0, n_sectors * SECTOR_SIZE); memset(buf, 0, n_sectors * SECTOR_SIZE);
ret = 0; ret = 0;
} else { } else {
uint64_t offset = s->header.offset_data / SECTOR_SIZE + uint64_t offset = s->header.offset_data / SECTOR_SIZE +
(uint64_t)bmap_entry * s->block_sectors + (uint64_t)bmap_entry * s->block_sectors +
sector_in_block; sector_in_block;
ret = bdrv_read(bs->file, offset, buf, n_sectors); ret = bdrv_read(bs->file, offset, buf, n_sectors);
} }
logout("%u sectors read\n", n_sectors); logout("%u sectors read\n", n_sectors);
nb_sectors -= n_sectors; nb_sectors -= n_sectors;
sector_num += n_sectors; sector_num += n_sectors;
buf += n_sectors * SECTOR_SIZE; buf += n_sectors * SECTOR_SIZE;
if (ret >= 0 && nb_sectors > 0) {
goto restart;
} }
return ret; return ret;
@ -525,57 +522,55 @@ static int vdi_co_write(BlockDriverState *bs,
uint32_t bmap_first = VDI_UNALLOCATED; uint32_t bmap_first = VDI_UNALLOCATED;
uint32_t bmap_last = VDI_UNALLOCATED; uint32_t bmap_last = VDI_UNALLOCATED;
uint8_t *block = NULL; uint8_t *block = NULL;
int ret; int ret = 0;
logout("\n"); logout("\n");
restart: while (ret >= 0 && nb_sectors > 0) {
block_index = sector_num / s->block_sectors; block_index = sector_num / s->block_sectors;
sector_in_block = sector_num % s->block_sectors; sector_in_block = sector_num % s->block_sectors;
n_sectors = s->block_sectors - sector_in_block; n_sectors = s->block_sectors - sector_in_block;
if (n_sectors > nb_sectors) { if (n_sectors > nb_sectors) {
n_sectors = nb_sectors; n_sectors = nb_sectors;
}
logout("will write %u sectors starting at sector %" PRIu64 "\n",
n_sectors, sector_num);
/* prepare next AIO request */
bmap_entry = le32_to_cpu(s->bmap[block_index]);
if (!VDI_IS_ALLOCATED(bmap_entry)) {
/* Allocate new block and write to it. */
uint64_t offset;
bmap_entry = s->header.blocks_allocated;
s->bmap[block_index] = cpu_to_le32(bmap_entry);
s->header.blocks_allocated++;
offset = s->header.offset_data / SECTOR_SIZE +
(uint64_t)bmap_entry * s->block_sectors;
if (block == NULL) {
block = g_malloc(s->block_size);
bmap_first = block_index;
} }
bmap_last = block_index;
/* Copy data to be written to new block and zero unused parts. */
memset(block, 0, sector_in_block * SECTOR_SIZE);
memcpy(block + sector_in_block * SECTOR_SIZE,
buf, n_sectors * SECTOR_SIZE);
memset(block + (sector_in_block + n_sectors) * SECTOR_SIZE, 0,
(s->block_sectors - n_sectors - sector_in_block) * SECTOR_SIZE);
ret = bdrv_write(bs->file, offset, block, s->block_sectors);
} else {
uint64_t offset = s->header.offset_data / SECTOR_SIZE +
(uint64_t)bmap_entry * s->block_sectors +
sector_in_block;
ret = bdrv_write(bs->file, offset, buf, n_sectors);
}
nb_sectors -= n_sectors; logout("will write %u sectors starting at sector %" PRIu64 "\n",
sector_num += n_sectors; n_sectors, sector_num);
buf += n_sectors * SECTOR_SIZE;
logout("%u sectors written\n", n_sectors); /* prepare next AIO request */
if (ret >= 0 && nb_sectors > 0) { bmap_entry = le32_to_cpu(s->bmap[block_index]);
goto restart; if (!VDI_IS_ALLOCATED(bmap_entry)) {
/* Allocate new block and write to it. */
uint64_t offset;
bmap_entry = s->header.blocks_allocated;
s->bmap[block_index] = cpu_to_le32(bmap_entry);
s->header.blocks_allocated++;
offset = s->header.offset_data / SECTOR_SIZE +
(uint64_t)bmap_entry * s->block_sectors;
if (block == NULL) {
block = g_malloc(s->block_size);
bmap_first = block_index;
}
bmap_last = block_index;
/* Copy data to be written to new block and zero unused parts. */
memset(block, 0, sector_in_block * SECTOR_SIZE);
memcpy(block + sector_in_block * SECTOR_SIZE,
buf, n_sectors * SECTOR_SIZE);
memset(block + (sector_in_block + n_sectors) * SECTOR_SIZE, 0,
(s->block_sectors - n_sectors - sector_in_block) * SECTOR_SIZE);
ret = bdrv_write(bs->file, offset, block, s->block_sectors);
} else {
uint64_t offset = s->header.offset_data / SECTOR_SIZE +
(uint64_t)bmap_entry * s->block_sectors +
sector_in_block;
ret = bdrv_write(bs->file, offset, buf, n_sectors);
}
nb_sectors -= n_sectors;
sector_num += n_sectors;
buf += n_sectors * SECTOR_SIZE;
logout("%u sectors written\n", n_sectors);
} }
logout("finished data write\n"); logout("finished data write\n");