david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

char: fix avail_connections init in qemu_chr_open_eventfd()

Browse Source 
When trying to use a ivshmem server with qemu, ivshmem init code tries to
create a CharDriverState object for each eventfd retrieved from the server.
To create this object, a call to qemu_chr_open_eventfd() is done.
Right after this, before adding a frontend, qemu_chr_fe_claim_no_fail() is
called.
qemu_chr_open_eventfd() does not set avail_connections to 1, so no frontend can
be associated because qemu_chr_fe_claim_no_fail() makes qemu stop right away.

This problem comes from 456d60692310e7ac25cf822cc1e98192ad636ece
"qemu-char: Call fe_claim / fe_release when not using qdev chr properties".

Fix this, by setting avail_connections to 1 in qemu_chr_open_eventfd().

Signed-off-by: David Marchand <david.marchand@6wind.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
David Marchand 2014-06-11 17:25:16 +02:00 committed by Gerd Hoffmann
parent 2a2c4830c0
commit e9d21c436f
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qemu-char.c
View File

@ -2493,7 +2493,13 @@ static gboolean tcp_chr_read(GIOChannel *chan, GIOCondition cond, void *opaque)
#ifndef _WIN32 #ifndef _WIN32
CharDriverState *qemu_chr_open_eventfd(int eventfd) CharDriverState *qemu_chr_open_eventfd(int eventfd)
{ {
return qemu_chr_open_fd(eventfd, eventfd); CharDriverState *chr = qemu_chr_open_fd(eventfd, eventfd);
if (chr) {
chr->avail_connections = 1;
}
return chr;
} }
#endif #endif