david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qemu-sockets: avoid strlen of NULL pointer

Browse Source 
If the user wants to create a chardev of type socket but forgets to give a
host= option, qemu_opt_get returns NULL. This NULL pointer is then fed into
strlen a few lines below without a check which results in a segfault.
This fixes it.

Signed-off-by: Jens Osterkamp <jens@linux.vnet.ibm.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
This commit is contained in:
Jens Osterkamp 2010-04-12 10:51:01 +02:00 committed by Aurelien Jarno
parent 81bbe906c8
commit e23a22e620
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qemu-sockets.c
View File

@ -130,7 +130,8 @@ int inet_listen_opts(QemuOpts *opts, int port_offset)
ai.ai_family = PF_UNSPEC; ai.ai_family = PF_UNSPEC;
ai.ai_socktype = SOCK_STREAM; ai.ai_socktype = SOCK_STREAM;
if (qemu_opt_get(opts, "port") == NULL) { if ((qemu_opt_get(opts, "host") == NULL) ||
(qemu_opt_get(opts, "port") == NULL)) {
fprintf(stderr, "%s: host and/or port not specified\n", __FUNCTION__); fprintf(stderr, "%s: host and/or port not specified\n", __FUNCTION__);
return -1; return -1;
} }