david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qdev: Use object_property_print() in info qtree

Browse Source 
Otherwise, non-string properties without a legacy counterpart are missed.
Also fix error propagation in object_property_print() itself.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
This commit is contained in:
Paolo Bonzini 2012-05-02 13:31:00 +02:00 committed by Andreas Färber
parent 7a05995361
commit 8185bfc146
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/qdev-monitor.c
View File

@ -493,7 +493,7 @@ static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props,
if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) { if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) {
value = object_property_get_str(OBJECT(dev), legacy_name, &err); value = object_property_get_str(OBJECT(dev), legacy_name, &err);
} else { } else {
value = object_property_get_str(OBJECT(dev), props->name, &err); value = object_property_print(OBJECT(dev), props->name, &err);
} }
g_free(legacy_name); g_free(legacy_name);

2
qom/object.c
View File

@ -830,7 +830,7 @@ char *object_property_print(Object *obj, const char *name,
char *string; char *string;
mo = string_output_visitor_new(); mo = string_output_visitor_new();
object_property_get(obj, string_output_get_visitor(mo), name, NULL); object_property_get(obj, string_output_get_visitor(mo), name, errp);
string = string_output_get_string(mo); string = string_output_get_string(mo);
string_output_visitor_cleanup(mo); string_output_visitor_cleanup(mo);
return string; return string;