david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

block: vhdx - minor comments and typo correction.

Browse Source 
Just a couple of minor comments to help note where allocated
buffers are freed, and a typo fix.

Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Jeff Cody 2013-10-30 10:44:38 -04:00 committed by Stefan Hajnoczi
parent 0173e7bbf3
commit 6e9d290bf6
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
block/vhdx.c
View File

@ -6,9 +6,9 @@
* Authors: * Authors:
* Jeff Cody <jcody@redhat.com> * Jeff Cody <jcody@redhat.com>
* *
* This is based on the "VHDX Format Specification v0.95", published 4/12/2012 * This is based on the "VHDX Format Specification v1.00", published 8/25/2012
* by Microsoft: * by Microsoft:
* https://www.microsoft.com/en-us/download/details.aspx?id=29681 * https://www.microsoft.com/en-us/download/details.aspx?id=34750
* *
* This work is licensed under the terms of the GNU LGPL, version 2 or later. * This work is licensed under the terms of the GNU LGPL, version 2 or later.
* See the COPYING.LIB file in the top-level directory. * See the COPYING.LIB file in the top-level directory.
@ -264,6 +264,7 @@ static int vhdx_parse_header(BlockDriverState *bs, BDRVVHDXState *s)
uint64_t h2_seq = 0; uint64_t h2_seq = 0;
uint8_t *buffer; uint8_t *buffer;
/* header1 & header2 are freed in vhdx_close() */
header1 = qemu_blockalign(bs, sizeof(VHDXHeader)); header1 = qemu_blockalign(bs, sizeof(VHDXHeader));
header2 = qemu_blockalign(bs, sizeof(VHDXHeader)); header2 = qemu_blockalign(bs, sizeof(VHDXHeader));
@ -790,6 +791,7 @@ static int vhdx_open(BlockDriverState *bs, QDict *options, int flags,
goto fail; goto fail;
} }
/* s->bat is freed in vhdx_close() */
s->bat = qemu_blockalign(bs, s->bat_rt.length); s->bat = qemu_blockalign(bs, s->bat_rt.length);
ret = bdrv_pread(bs->file, s->bat_offset, s->bat, s->bat_rt.length); ret = bdrv_pread(bs->file, s->bat_offset, s->bat, s->bat_rt.length);

4
block/vhdx.h
View File

@ -6,9 +6,9 @@
* Authors: * Authors:
* Jeff Cody <jcody@redhat.com> * Jeff Cody <jcody@redhat.com>
* *
* This is based on the "VHDX Format Specification v0.95", published 4/12/2012 * This is based on the "VHDX Format Specification v1.00", published 8/25/2012
* by Microsoft: * by Microsoft:
* https://www.microsoft.com/en-us/download/details.aspx?id=29681 * https://www.microsoft.com/en-us/download/details.aspx?id=34750
* *
* This work is licensed under the terms of the GNU LGPL, version 2 or later. * This work is licensed under the terms of the GNU LGPL, version 2 or later.
* See the COPYING.LIB file in the top-level directory. * See the COPYING.LIB file in the top-level directory.