target/riscv: convert to TranslatorOps

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Michael Clark <mjc@sifive.com>
Cc: Palmer Dabbelt <palmer@sifive.com>
Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Emilio G. Cota 2018-04-06 13:42:27 -04:00 committed by Richard Henderson
parent 0114db1c82
commit 5b4f1d2db9

View File

@ -1837,78 +1837,71 @@ static void decode_opc(CPURISCVState *env, DisasContext *ctx)
} }
} }
void gen_intermediate_code(CPUState *cs, TranslationBlock *tb) static void riscv_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)
{ {
CPURISCVState *env = cs->env_ptr; DisasContext *ctx = container_of(dcbase, DisasContext, base);
DisasContext ctx;
target_ulong page_start;
int num_insns;
int max_insns;
ctx.base.pc_first = tb->pc; ctx->pc_succ_insn = ctx->base.pc_first;
ctx.base.pc_next = ctx.base.pc_first; ctx->flags = ctx->base.tb->flags;
/* once we have GDB, the rest of the translate.c implementation should be ctx->mem_idx = ctx->base.tb->flags & TB_FLAGS_MMU_MASK;
ready for singlestep */ ctx->frm = -1; /* unknown rounding mode */
ctx.base.singlestep_enabled = cs->singlestep_enabled; }
ctx.base.tb = tb;
ctx.base.is_jmp = DISAS_NEXT;
page_start = ctx.base.pc_first & TARGET_PAGE_MASK; static void riscv_tr_tb_start(DisasContextBase *db, CPUState *cpu)
ctx.pc_succ_insn = ctx.base.pc_first; {
ctx.flags = tb->flags; }
ctx.mem_idx = tb->flags & TB_FLAGS_MMU_MASK;
ctx.frm = -1; /* unknown rounding mode */
num_insns = 0; static void riscv_tr_insn_start(DisasContextBase *dcbase, CPUState *cpu)
max_insns = tb_cflags(ctx.base.tb) & CF_COUNT_MASK; {
if (max_insns == 0) { DisasContext *ctx = container_of(dcbase, DisasContext, base);
max_insns = CF_COUNT_MASK;
}
if (max_insns > TCG_MAX_INSNS) {
max_insns = TCG_MAX_INSNS;
}
gen_tb_start(tb);
while (ctx.base.is_jmp == DISAS_NEXT) { tcg_gen_insn_start(ctx->base.pc_next);
tcg_gen_insn_start(ctx.base.pc_next); }
num_insns++;
if (unlikely(cpu_breakpoint_test(cs, ctx.base.pc_next, BP_ANY))) { static bool riscv_tr_breakpoint_check(DisasContextBase *dcbase, CPUState *cpu,
tcg_gen_movi_tl(cpu_pc, ctx.base.pc_next); const CPUBreakpoint *bp)
ctx.base.is_jmp = DISAS_NORETURN; {
DisasContext *ctx = container_of(dcbase, DisasContext, base);
tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next);
ctx->base.is_jmp = DISAS_NORETURN;
gen_exception_debug(); gen_exception_debug();
/* The address covered by the breakpoint must be included in /* The address covered by the breakpoint must be included in
[tb->pc, tb->pc + tb->size) in order to for it to be [tb->pc, tb->pc + tb->size) in order to for it to be
properly cleared -- thus we increment the PC here so that properly cleared -- thus we increment the PC here so that
the logic setting tb->size below does the right thing. */ the logic setting tb->size below does the right thing. */
ctx.base.pc_next += 4; ctx->base.pc_next += 4;
goto done_generating; return true;
} }
if (num_insns == max_insns && (tb_cflags(ctx.base.tb) & CF_LAST_IO)) {
gen_io_start();
}
ctx.opcode = cpu_ldl_code(env, ctx.base.pc_next); static void riscv_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
decode_opc(env, &ctx); {
ctx.base.pc_next = ctx.pc_succ_insn; DisasContext *ctx = container_of(dcbase, DisasContext, base);
CPURISCVState *env = cpu->env_ptr;
if (ctx.base.is_jmp == DISAS_NEXT && ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next);
(cs->singlestep_enabled || decode_opc(env, ctx);
ctx.base.pc_next - page_start >= TARGET_PAGE_SIZE || ctx->base.pc_next = ctx->pc_succ_insn;
tcg_op_buf_full() ||
num_insns >= max_insns || if (ctx->base.is_jmp == DISAS_NEXT) {
singlestep)) { target_ulong page_start;
ctx.base.is_jmp = DISAS_TOO_MANY;
page_start = ctx->base.pc_first & TARGET_PAGE_MASK;
if (ctx->base.pc_next - page_start >= TARGET_PAGE_SIZE) {
ctx->base.is_jmp = DISAS_TOO_MANY;
} }
} }
if (tb_cflags(ctx.base.tb) & CF_LAST_IO) { }
gen_io_end();
} static void riscv_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu)
switch (ctx.base.is_jmp) { {
DisasContext *ctx = container_of(dcbase, DisasContext, base);
switch (ctx->base.is_jmp) {
case DISAS_TOO_MANY: case DISAS_TOO_MANY:
tcg_gen_movi_tl(cpu_pc, ctx.base.pc_next); tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next);
if (cs->singlestep_enabled) { if (ctx->base.singlestep_enabled) {
gen_exception_debug(); gen_exception_debug();
} else { } else {
tcg_gen_exit_tb(0); tcg_gen_exit_tb(0);
@ -1919,20 +1912,29 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)
default: default:
g_assert_not_reached(); g_assert_not_reached();
} }
done_generating: }
gen_tb_end(tb, num_insns);
tb->size = ctx.base.pc_next - ctx.base.pc_first;
tb->icount = num_insns;
#ifdef DEBUG_DISAS static void riscv_tr_disas_log(const DisasContextBase *dcbase, CPUState *cpu)
if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) {
&& qemu_log_in_addr_range(ctx.base.pc_first)) { qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first));
qemu_log("IN: %s\n", lookup_symbol(ctx.base.pc_first)); log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size);
log_target_disas(cs, ctx.base.pc_first, }
ctx.base.pc_next - ctx.base.pc_first);
qemu_log("\n"); static const TranslatorOps riscv_tr_ops = {
} .init_disas_context = riscv_tr_init_disas_context,
#endif .tb_start = riscv_tr_tb_start,
.insn_start = riscv_tr_insn_start,
.breakpoint_check = riscv_tr_breakpoint_check,
.translate_insn = riscv_tr_translate_insn,
.tb_stop = riscv_tr_tb_stop,
.disas_log = riscv_tr_disas_log,
};
void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)
{
DisasContext ctx;
translator_loop(&riscv_tr_ops, &ctx.base, cs, tb);
} }
void riscv_translate_init(void) void riscv_translate_init(void)