david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hw/net/rocker: Don't use *_to_cpup()

Browse Source 
Don't use *_to_cpup() to do byte-swapped loads; instead use
ld*_p() which correctly handle misaligned accesses.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Dmitry Fleytman <dmitry@daynix.com <mailto:dmitry@daynix.com>>
Message-id: 1466097446-981-4-git-send-email-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2016-06-16 18:17:24 +01:00
parent 6960bfca3a
commit 4071887b58
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/net/rocker/rocker_tlv.h
View File

@ -106,17 +106,17 @@ static inline uint64_t rocker_tlv_get_u64(const RockerTlv *tlv)
static inline uint16_t rocker_tlv_get_le16(const RockerTlv *tlv) static inline uint16_t rocker_tlv_get_le16(const RockerTlv *tlv)
{ {
return le16_to_cpup((uint16_t *) rocker_tlv_data(tlv)); return lduw_le_p(rocker_tlv_data(tlv));
} }
static inline uint32_t rocker_tlv_get_le32(const RockerTlv *tlv) static inline uint32_t rocker_tlv_get_le32(const RockerTlv *tlv)
{ {
return le32_to_cpup((uint32_t *) rocker_tlv_data(tlv)); return ldl_le_p(rocker_tlv_data(tlv));
} }
static inline uint64_t rocker_tlv_get_le64(const RockerTlv *tlv) static inline uint64_t rocker_tlv_get_le64(const RockerTlv *tlv)
{ {
return le64_to_cpup((uint64_t *) rocker_tlv_data(tlv)); return ldq_le_p(rocker_tlv_data(tlv));
} }
static inline void rocker_tlv_parse(RockerTlv **tb, int maxtype, static inline void rocker_tlv_parse(RockerTlv **tb, int maxtype,