Coverity points out that we aren't checking the return value from curl_easy_setopt(). Fixes: Coverity CID 1458895 Inspired-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu> Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu> Message-id: 20210910170656.366592-2-philmd@redhat.com Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
		
			
				
	
	
		
			46 lines
		
	
	
		
			1.0 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			46 lines
		
	
	
		
			1.0 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Copyright (c) 2018 Virtuozzo International GmbH
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | 
						|
 *
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include <curl/curl.h>
 | 
						|
#include "download.h"
 | 
						|
 | 
						|
int download_url(const char *name, const char *url)
 | 
						|
{
 | 
						|
    int err = 0;
 | 
						|
    FILE *file;
 | 
						|
    CURL *curl = curl_easy_init();
 | 
						|
 | 
						|
    if (!curl) {
 | 
						|
        return 1;
 | 
						|
    }
 | 
						|
 | 
						|
    file = fopen(name, "wb");
 | 
						|
    if (!file) {
 | 
						|
        err = 1;
 | 
						|
        goto out_curl;
 | 
						|
    }
 | 
						|
 | 
						|
    if (curl_easy_setopt(curl, CURLOPT_URL, url) != CURLE_OK
 | 
						|
            || curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, NULL) != CURLE_OK
 | 
						|
            || curl_easy_setopt(curl, CURLOPT_WRITEDATA, file) != CURLE_OK
 | 
						|
            || curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1) != CURLE_OK
 | 
						|
            || curl_easy_setopt(curl, CURLOPT_NOPROGRESS, 0) != CURLE_OK
 | 
						|
            || curl_easy_perform(curl) != CURLE_OK) {
 | 
						|
        unlink(name);
 | 
						|
        fclose(file);
 | 
						|
        err = 1;
 | 
						|
    } else {
 | 
						|
        err = fclose(file);
 | 
						|
    }
 | 
						|
 | 
						|
out_curl:
 | 
						|
    curl_easy_cleanup(curl);
 | 
						|
 | 
						|
    return err;
 | 
						|
}
 |