Also fixes a GCC 12.0.1 false-positive:
../hw/arm/digic.c: In function ‘digic_init’:
../hw/arm/digic.c:45:54: error: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 5 [-Werror=format-truncation=]
   45 |         snprintf(name, DIGIC_TIMER_NAME_MLEN, "timer[%d]", i);
      |                                                      ^~
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-14-marcandre.lureau@redhat.com>
		
	
			
		
			
				
	
	
		
			105 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			105 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QEMU model of the Canon DIGIC SoC.
 | 
						|
 *
 | 
						|
 * Copyright (C) 2013 Antony Pavlov <antonynpavlov@gmail.com>
 | 
						|
 *
 | 
						|
 * This model is based on reverse engineering efforts
 | 
						|
 * made by CHDK (http://chdk.wikia.com) and
 | 
						|
 * Magic Lantern (http://www.magiclantern.fm) projects
 | 
						|
 * contributors.
 | 
						|
 *
 | 
						|
 * This program is free software; you can redistribute it and/or modify
 | 
						|
 * it under the terms of the GNU General Public License as published by
 | 
						|
 * the Free Software Foundation; either version 2 of the License, or
 | 
						|
 * (at your option) any later version.
 | 
						|
 *
 | 
						|
 * This program is distributed in the hope that it will be useful,
 | 
						|
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 | 
						|
 * GNU General Public License for more details.
 | 
						|
 *
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "qapi/error.h"
 | 
						|
#include "qemu/module.h"
 | 
						|
#include "hw/arm/digic.h"
 | 
						|
#include "hw/qdev-properties.h"
 | 
						|
#include "sysemu/sysemu.h"
 | 
						|
 | 
						|
#define DIGIC4_TIMER_BASE(n)    (0xc0210000 + (n) * 0x100)
 | 
						|
 | 
						|
#define DIGIC_UART_BASE          0xc0800000
 | 
						|
 | 
						|
static void digic_init(Object *obj)
 | 
						|
{
 | 
						|
    DigicState *s = DIGIC(obj);
 | 
						|
    int i;
 | 
						|
 | 
						|
    object_initialize_child(obj, "cpu", &s->cpu, ARM_CPU_TYPE_NAME("arm946"));
 | 
						|
 | 
						|
    for (i = 0; i < DIGIC4_NB_TIMERS; i++) {
 | 
						|
        g_autofree char *name = g_strdup_printf("timer[%d]", i);
 | 
						|
        object_initialize_child(obj, name, &s->timer[i], TYPE_DIGIC_TIMER);
 | 
						|
    }
 | 
						|
 | 
						|
    object_initialize_child(obj, "uart", &s->uart, TYPE_DIGIC_UART);
 | 
						|
}
 | 
						|
 | 
						|
static void digic_realize(DeviceState *dev, Error **errp)
 | 
						|
{
 | 
						|
    DigicState *s = DIGIC(dev);
 | 
						|
    SysBusDevice *sbd;
 | 
						|
    int i;
 | 
						|
 | 
						|
    if (!object_property_set_bool(OBJECT(&s->cpu), "reset-hivecs", true,
 | 
						|
                                  errp)) {
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    if (!qdev_realize(DEVICE(&s->cpu), NULL, errp)) {
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    for (i = 0; i < DIGIC4_NB_TIMERS; i++) {
 | 
						|
        if (!sysbus_realize(SYS_BUS_DEVICE(&s->timer[i]), errp)) {
 | 
						|
            return;
 | 
						|
        }
 | 
						|
 | 
						|
        sbd = SYS_BUS_DEVICE(&s->timer[i]);
 | 
						|
        sysbus_mmio_map(sbd, 0, DIGIC4_TIMER_BASE(i));
 | 
						|
    }
 | 
						|
 | 
						|
    qdev_prop_set_chr(DEVICE(&s->uart), "chardev", serial_hd(0));
 | 
						|
    if (!sysbus_realize(SYS_BUS_DEVICE(&s->uart), errp)) {
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    sbd = SYS_BUS_DEVICE(&s->uart);
 | 
						|
    sysbus_mmio_map(sbd, 0, DIGIC_UART_BASE);
 | 
						|
}
 | 
						|
 | 
						|
static void digic_class_init(ObjectClass *oc, void *data)
 | 
						|
{
 | 
						|
    DeviceClass *dc = DEVICE_CLASS(oc);
 | 
						|
 | 
						|
    dc->realize = digic_realize;
 | 
						|
    /* Reason: Uses serial_hds in the realize function --> not usable twice */
 | 
						|
    dc->user_creatable = false;
 | 
						|
}
 | 
						|
 | 
						|
static const TypeInfo digic_type_info = {
 | 
						|
    .name = TYPE_DIGIC,
 | 
						|
    .parent = TYPE_DEVICE,
 | 
						|
    .instance_size = sizeof(DigicState),
 | 
						|
    .instance_init = digic_init,
 | 
						|
    .class_init = digic_class_init,
 | 
						|
};
 | 
						|
 | 
						|
static void digic_register_types(void)
 | 
						|
{
 | 
						|
    type_register_static(&digic_type_info);
 | 
						|
}
 | 
						|
 | 
						|
type_init(digic_register_types)
 |