 7562f90707
			
		
	
	
		7562f90707
		
	
	
	
	
		
			
			Commit a3a3d8c7 introduced a segfault bug while checking for 'dc->vmsd->unmigratable' which caused QEMU to crash when trying to add devices which do no set their 'dc->vmsd' yet while initialization. Place a 'dc->vmsd' check prior to it so that we do not segfault for such devices. NOTE: This doesn't compromise the functioning of --only-migratable option as all the unmigratable devices do set their 'dc->vmsd'. Introduce a new function check_migratable() and move the only_migratable check inside it, also use stubs to avoid user-mode qemu build failures. Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com> Message-Id: <1487009088-23891-1-git-send-email-ashijeetacharya@gmail.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
		
			
				
	
	
		
			28 lines
		
	
	
		
			728 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			28 lines
		
	
	
		
			728 B
		
	
	
	
		
			C
		
	
	
	
	
	
| #include "qemu/osdep.h"
 | |
| #include "qemu-common.h"
 | |
| #include "migration/vmstate.h"
 | |
| #include "migration/migration.h"
 | |
| 
 | |
| const VMStateDescription vmstate_dummy = {};
 | |
| 
 | |
| int vmstate_register_with_alias_id(DeviceState *dev,
 | |
|                                    int instance_id,
 | |
|                                    const VMStateDescription *vmsd,
 | |
|                                    void *base, int alias_id,
 | |
|                                    int required_for_version,
 | |
|                                    Error **errp)
 | |
| {
 | |
|     return 0;
 | |
| }
 | |
| 
 | |
| void vmstate_unregister(DeviceState *dev,
 | |
|                         const VMStateDescription *vmsd,
 | |
|                         void *opaque)
 | |
| {
 | |
| }
 | |
| 
 | |
| int check_migratable(Object *obj, Error **err)
 | |
| {
 | |
|     return 0;
 | |
| }
 |