 e1b72c55b1
			
		
	
	
		e1b72c55b1
		
	
	
	
	
		
			
			Both 'netduinoplus2' and 'olimex-stm32-h405' machines ignore the CPU type requested by the command line. This might confuse users, since the following will create a machine with a Cortex-M4 CPU: $ qemu-system-aarch64 -M netduinoplus2 -cpu cortex-r5f Set the MachineClass::valid_cpu_types field (introduced in commit c9cf636d48 "machine: Add a valid_cpu_types property"). Remove the now unused MachineClass::default_cpu_type field. We now get: $ qemu-system-aarch64 -M netduinoplus2 -cpu cortex-r5f qemu-system-aarch64: Invalid CPU type: cortex-r5f-arm-cpu The valid types are: cortex-m4-arm-cpu Since the SoC family can only use Cortex-M4 CPUs, hard-code the CPU type name at the SoC level, removing the QOM property entirely. Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Gavin Shan <gshan@redhat.com> Message-id: 20231117071704.35040-3-philmd@linaro.org Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
		
			
				
	
	
		
			74 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			74 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * ST STM32VLDISCOVERY machine
 | |
|  * Olimex STM32-H405 machine
 | |
|  *
 | |
|  * Copyright (c) 2022 Felipe Balbi <balbi@kernel.org>
 | |
|  *
 | |
|  * Permission is hereby granted, free of charge, to any person obtaining a copy
 | |
|  * of this software and associated documentation files (the "Software"), to deal
 | |
|  * in the Software without restriction, including without limitation the rights
 | |
|  * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 | |
|  * copies of the Software, and to permit persons to whom the Software is
 | |
|  * furnished to do so, subject to the following conditions:
 | |
|  *
 | |
|  * The above copyright notice and this permission notice shall be included in
 | |
|  * all copies or substantial portions of the Software.
 | |
|  *
 | |
|  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 | |
|  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 | |
|  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
 | |
|  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 | |
|  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 | |
|  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 | |
|  * THE SOFTWARE.
 | |
|  */
 | |
| 
 | |
| #include "qemu/osdep.h"
 | |
| #include "qapi/error.h"
 | |
| #include "hw/boards.h"
 | |
| #include "hw/qdev-properties.h"
 | |
| #include "hw/qdev-clock.h"
 | |
| #include "qemu/error-report.h"
 | |
| #include "hw/arm/stm32f405_soc.h"
 | |
| #include "hw/arm/boot.h"
 | |
| 
 | |
| /* olimex-stm32-h405 implementation is derived from netduinoplus2 */
 | |
| 
 | |
| /* Main SYSCLK frequency in Hz (168MHz) */
 | |
| #define SYSCLK_FRQ 168000000ULL
 | |
| 
 | |
| static void olimex_stm32_h405_init(MachineState *machine)
 | |
| {
 | |
|     DeviceState *dev;
 | |
|     Clock *sysclk;
 | |
| 
 | |
|     /* This clock doesn't need migration because it is fixed-frequency */
 | |
|     sysclk = clock_new(OBJECT(machine), "SYSCLK");
 | |
|     clock_set_hz(sysclk, SYSCLK_FRQ);
 | |
| 
 | |
|     dev = qdev_new(TYPE_STM32F405_SOC);
 | |
|     qdev_connect_clock_in(dev, "sysclk", sysclk);
 | |
|     sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
 | |
| 
 | |
|     armv7m_load_kernel(ARM_CPU(first_cpu),
 | |
|                        machine->kernel_filename,
 | |
|                        0, FLASH_SIZE);
 | |
| }
 | |
| 
 | |
| static void olimex_stm32_h405_machine_init(MachineClass *mc)
 | |
| {
 | |
|     static const char * const valid_cpu_types[] = {
 | |
|         ARM_CPU_TYPE_NAME("cortex-m4"),
 | |
|         NULL
 | |
|     };
 | |
| 
 | |
|     mc->desc = "Olimex STM32-H405 (Cortex-M4)";
 | |
|     mc->init = olimex_stm32_h405_init;
 | |
|     mc->valid_cpu_types = valid_cpu_types;
 | |
| 
 | |
|     /* SRAM pre-allocated as part of the SoC instantiation */
 | |
|     mc->default_ram_size = 0;
 | |
| }
 | |
| 
 | |
| DEFINE_MACHINE("olimex-stm32-h405", olimex_stm32_h405_machine_init)
 |