65c2ab8085
On resume igb_vm_state_change() always calls igb_autoneg_resume()
that sets link_down to false, and thus activates the link even
if we have disabled it.
The problem can be reproduced starting qemu in paused state (-S) and
then set the link to down. When we resume the machine the link appears
to be up.
Reproducer:
# qemu-system-x86_64 ... -device igb,netdev=netdev0,id=net0 -S
{"execute": "qmp_capabilities" }
{"execute": "set_link", "arguments": {"name": "net0", "up": false}}
{"execute": "cont" }
To fix the problem, merge the content of igb_vm_state_change()
into igb_core_post_load() as e1000 does.
Buglink: https://issues.redhat.com/browse/RHEL-21867
Fixes: 3a977deebe6b ("Intrdocue igb device emulation")
Cc: akihiko.odaki@daynix.com
Suggested-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
147 lines
3.6 KiB
C
147 lines
3.6 KiB
C
/*
|
|
* Core code for QEMU igb emulation
|
|
*
|
|
* Datasheet:
|
|
* https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82576eg-gbe-datasheet.pdf
|
|
*
|
|
* Copyright (c) 2020-2023 Red Hat, Inc.
|
|
* Copyright (c) 2015 Ravello Systems LTD (http://ravellosystems.com)
|
|
* Developed by Daynix Computing LTD (http://www.daynix.com)
|
|
*
|
|
* Authors:
|
|
* Akihiko Odaki <akihiko.odaki@daynix.com>
|
|
* Gal Hammmer <gal.hammer@sap.com>
|
|
* Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
|
|
* Dmitry Fleytman <dmitry@daynix.com>
|
|
* Leonid Bloch <leonid@daynix.com>
|
|
* Yan Vugenfirer <yan@daynix.com>
|
|
*
|
|
* Based on work done by:
|
|
* Nir Peleg, Tutis Systems Ltd. for Qumranet Inc.
|
|
* Copyright (c) 2008 Qumranet
|
|
* Based on work done by:
|
|
* Copyright (c) 2007 Dan Aloni
|
|
* Copyright (c) 2004 Antony T Curtis
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef HW_NET_IGB_CORE_H
|
|
#define HW_NET_IGB_CORE_H
|
|
|
|
#define E1000E_MAC_SIZE (0x8000)
|
|
#define IGB_EEPROM_SIZE (1024)
|
|
|
|
#define IGB_INTR_NUM (25)
|
|
#define IGB_MSIX_VEC_NUM (10)
|
|
#define IGBVF_MSIX_VEC_NUM (3)
|
|
#define IGB_NUM_QUEUES (16)
|
|
#define IGB_NUM_VM_POOLS (8)
|
|
|
|
typedef struct IGBCore IGBCore;
|
|
|
|
enum { PHY_R = BIT(0),
|
|
PHY_W = BIT(1),
|
|
PHY_RW = PHY_R | PHY_W };
|
|
|
|
typedef struct IGBIntrDelayTimer_st {
|
|
QEMUTimer *timer;
|
|
bool running;
|
|
uint32_t delay_reg;
|
|
uint32_t delay_resolution_ns;
|
|
IGBCore *core;
|
|
} IGBIntrDelayTimer;
|
|
|
|
struct IGBCore {
|
|
uint32_t mac[E1000E_MAC_SIZE];
|
|
uint16_t phy[MAX_PHY_REG_ADDRESS + 1];
|
|
uint16_t eeprom[IGB_EEPROM_SIZE];
|
|
|
|
uint8_t rx_desc_len;
|
|
|
|
QEMUTimer *autoneg_timer;
|
|
|
|
struct igb_tx {
|
|
struct e1000_adv_tx_context_desc ctx[2];
|
|
uint32_t first_cmd_type_len;
|
|
uint32_t first_olinfo_status;
|
|
|
|
bool first;
|
|
bool skip_cp;
|
|
|
|
struct NetTxPkt *tx_pkt;
|
|
} tx[IGB_NUM_QUEUES];
|
|
|
|
struct NetRxPkt *rx_pkt;
|
|
|
|
bool has_vnet;
|
|
int max_queue_num;
|
|
|
|
IGBIntrDelayTimer eitr[IGB_INTR_NUM];
|
|
|
|
uint32_t eitr_guest_value[IGB_INTR_NUM];
|
|
|
|
uint8_t permanent_mac[ETH_ALEN];
|
|
|
|
NICState *owner_nic;
|
|
PCIDevice *owner;
|
|
void (*owner_start_recv)(PCIDevice *d);
|
|
|
|
int64_t timadj;
|
|
};
|
|
|
|
void
|
|
igb_core_write(IGBCore *core, hwaddr addr, uint64_t val, unsigned size);
|
|
|
|
uint64_t
|
|
igb_core_read(IGBCore *core, hwaddr addr, unsigned size);
|
|
|
|
void
|
|
igb_core_pci_realize(IGBCore *regs,
|
|
const uint16_t *eeprom_templ,
|
|
uint32_t eeprom_size,
|
|
const uint8_t *macaddr);
|
|
|
|
void
|
|
igb_core_reset(IGBCore *core);
|
|
|
|
void
|
|
igb_core_pre_save(IGBCore *core);
|
|
|
|
int
|
|
igb_core_post_load(IGBCore *core);
|
|
|
|
void
|
|
igb_core_set_link_status(IGBCore *core);
|
|
|
|
void
|
|
igb_core_pci_uninit(IGBCore *core);
|
|
|
|
void
|
|
igb_core_vf_reset(IGBCore *core, uint16_t vfn);
|
|
|
|
bool
|
|
igb_can_receive(IGBCore *core);
|
|
|
|
ssize_t
|
|
igb_receive(IGBCore *core, const uint8_t *buf, size_t size);
|
|
|
|
ssize_t
|
|
igb_receive_iov(IGBCore *core, const struct iovec *iov, int iovcnt);
|
|
|
|
void
|
|
igb_start_recv(IGBCore *core);
|
|
|
|
#endif
|