Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the Error typedef. Since then, we've moved to include qemu/osdep.h everywhere. Its file comment explains: "To avoid getting into possible circular include dependencies, this file should not include any other QEMU headers, with the exceptions of config-host.h, compiler.h, os-posix.h and os-win32.h, all of which are doing a similar job to this file and are under similar constraints." qapi/error.h doesn't do a similar job, and it doesn't adhere to similar constraints: it includes qapi-types.h. That's in excess of 100KiB of crap most .c files don't actually need. Add the typedef to qemu/typedefs.h, and include that instead of qapi/error.h. Include qapi/error.h in .c files that need it and don't get it now. Include qapi-types.h in qom/object.h for uint16List. Update scripts/clean-includes accordingly. Update it further to match reality: replace config.h by config-target.h, add sysemu/os-posix.h, sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h comment quoted above similarly. This reduces the number of objects depending on qapi/error.h from "all of them" to less than a third. Unfortunately, the number depending on qapi-types.h shrinks only a little. More work is needed for that one. Signed-off-by: Markus Armbruster <armbru@redhat.com> [Fix compilation without the spice devel packages. - Paolo] Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
		
			
				
	
	
		
			56 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			56 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QEMU Host Memory Backend
 | 
						|
 *
 | 
						|
 * Copyright (C) 2013-2014 Red Hat Inc
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *   Igor Mammedov <imammedo@redhat.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | 
						|
 * See the COPYING file in the top-level directory.
 | 
						|
 */
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "sysemu/hostmem.h"
 | 
						|
#include "qapi/error.h"
 | 
						|
#include "qom/object_interfaces.h"
 | 
						|
 | 
						|
#define TYPE_MEMORY_BACKEND_RAM "memory-backend-ram"
 | 
						|
 | 
						|
 | 
						|
static void
 | 
						|
ram_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
 | 
						|
{
 | 
						|
    char *path;
 | 
						|
 | 
						|
    if (!backend->size) {
 | 
						|
        error_setg(errp, "can't create backend with size 0");
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    path = object_get_canonical_path_component(OBJECT(backend));
 | 
						|
    memory_region_init_ram(&backend->mr, OBJECT(backend), path,
 | 
						|
                           backend->size, errp);
 | 
						|
    g_free(path);
 | 
						|
}
 | 
						|
 | 
						|
static void
 | 
						|
ram_backend_class_init(ObjectClass *oc, void *data)
 | 
						|
{
 | 
						|
    HostMemoryBackendClass *bc = MEMORY_BACKEND_CLASS(oc);
 | 
						|
 | 
						|
    bc->alloc = ram_backend_memory_alloc;
 | 
						|
}
 | 
						|
 | 
						|
static const TypeInfo ram_backend_info = {
 | 
						|
    .name = TYPE_MEMORY_BACKEND_RAM,
 | 
						|
    .parent = TYPE_MEMORY_BACKEND,
 | 
						|
    .class_init = ram_backend_class_init,
 | 
						|
};
 | 
						|
 | 
						|
static void register_types(void)
 | 
						|
{
 | 
						|
    type_register_static(&ram_backend_info);
 | 
						|
}
 | 
						|
 | 
						|
type_init(register_types);
 |