0e72078128
With bash 5.1, the output of the following script changes:
a=("double space")
a=${a[@]:0:1}
echo "$a"
from "double space" to "double space", i.e. all white space is
preserved as-is. This is probably what we actually want here (judging
from the "...to accommodate pathnames with spaces" comment), but before
5.1, we would have to quote the ${} slice to get the same behavior.
In any case, without quoting, the reference output of many iotests is
different between bash 5.1 and pre-5.1, which is not very good. The
output of 5.1 is what we want, so whatever we do to get pre-5.1 to the
same result, it means we have to fix the reference output of basically
all tests that invoke _send_qemu_cmd (except the ones that only use
single spaces in the commands they invoke).
Instead of quoting the ${} slice (cmd="${$@: 1:...}"), we can also just
not use array slicing and replace the whole thing with a simple "cmd=$1;
shift", which works because all callers quote the whole $cmd argument
anyway.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20201217153803.101231-3-mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
40 lines
1.9 KiB
Plaintext
40 lines
1.9 KiB
Plaintext
QA output created by 173
|
|
Formatting 'TEST_DIR/image.base', fmt=IMGFMT size=104857600
|
|
Formatting 'TEST_DIR/image.snp1', fmt=IMGFMT size=104857600
|
|
|
|
=== Running QEMU, using block-stream to find backing image ===
|
|
|
|
{ 'execute': 'qmp_capabilities' }
|
|
{"return": {}}
|
|
{ 'arguments': {
|
|
'device': 'disk2',
|
|
'format': 'IMGFMT',
|
|
'mode': 'existing',
|
|
'snapshot-file': 'TEST_DIR/image.snp1',
|
|
'snapshot-node-name': 'snp1'
|
|
},
|
|
'execute': 'blockdev-snapshot-sync'
|
|
}
|
|
{"return": {}}
|
|
{ 'arguments': {
|
|
'backing-file': 'image.base',
|
|
'device': 'disk2',
|
|
'image-node-name': 'snp1'
|
|
},
|
|
'execute': 'change-backing-file'
|
|
}
|
|
{"return": {}}
|
|
{ 'arguments': {
|
|
'base': 'TEST_DIR/image.base',
|
|
'device': 'disk2'
|
|
},
|
|
'execute': 'block-stream'
|
|
}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "disk2"}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "disk2"}}
|
|
{"return": {}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "disk2"}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "disk2"}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "disk2", "len": 0, "offset": 0, "speed": 0, "type": "stream"}}
|
|
*** done
|