This query copies the kernel command line into the message buffer. It was previously stubbed out to return empty, this commit makes it reflect the arguments specified with `-append`. I observed the following peculiarities on my Pi 3B+: - If the buffer is shorter than the string, the response header gives the full length, but no data is actually copied. - No NUL terminator is added: even if the buffer is long enough to fit one, the buffer's original contents are preserved past the string's end. - The VC firmware adds the following extra parameters beside the user-supplied ones (via /boot/cmdline.txt): `video`, `vc_mem.mem_base` and `vc_mem.mem_size`. This is currently not implemented in qemu. Signed-off-by: Daniel Bertalan <dani@danielbertalan.dev> Message-id: 20230425103250.56653-1-dani@danielbertalan.dev Reviewed-by: Peter Maydell <peter.maydell@linaro.org> [PMM: added comment about NUL and short-buffer behaviour] Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
		
			
				
	
	
		
			38 lines
		
	
	
		
			805 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			38 lines
		
	
	
		
			805 B
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Raspberry Pi emulation (c) 2012 Gregory Estrade
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | 
						|
 * See the COPYING file in the top-level directory.
 | 
						|
 */
 | 
						|
 | 
						|
#ifndef BCM2835_PROPERTY_H
 | 
						|
#define BCM2835_PROPERTY_H
 | 
						|
 | 
						|
#include "hw/sysbus.h"
 | 
						|
#include "net/net.h"
 | 
						|
#include "hw/display/bcm2835_fb.h"
 | 
						|
#include "qom/object.h"
 | 
						|
 | 
						|
#define TYPE_BCM2835_PROPERTY "bcm2835-property"
 | 
						|
OBJECT_DECLARE_SIMPLE_TYPE(BCM2835PropertyState, BCM2835_PROPERTY)
 | 
						|
 | 
						|
struct BCM2835PropertyState {
 | 
						|
    /*< private >*/
 | 
						|
    SysBusDevice busdev;
 | 
						|
    /*< public >*/
 | 
						|
 | 
						|
    MemoryRegion *dma_mr;
 | 
						|
    AddressSpace dma_as;
 | 
						|
    MemoryRegion iomem;
 | 
						|
    qemu_irq mbox_irq;
 | 
						|
    BCM2835FBState *fbdev;
 | 
						|
 | 
						|
    MACAddr macaddr;
 | 
						|
    uint32_t board_rev;
 | 
						|
    uint32_t addr;
 | 
						|
    char *command_line;
 | 
						|
    bool pending;
 | 
						|
};
 | 
						|
 | 
						|
#endif
 |