 30722e0445
			
		
	
	
		30722e0445
		
	
	
	
	
		
			
			The hw/arm/boot.h include in common-semi-target.h is not actually needed, and it's a bit odd because it pulls a hw/arm header into a target/arm file. This include was originally needed because the semihosting code used the arm_boot_info struct to get the base address of the RAM in system emulation, to use in a (bad) heuristic for the return values for the SYS_HEAPINFO semihosting call. We've since overhauled how we calculate the HEAPINFO values in system emulation, and the code no longer uses the arm_boot_info struct. Remove the now-redundant include line, and instead directly include the cpu-qom.h header that we were previously getting via boot.h. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-id: 20230925112219.3919261-1-peter.maydell@linaro.org
		
			
				
	
	
		
			61 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			61 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * Target-specific parts of semihosting/arm-compat-semi.c.
 | |
|  *
 | |
|  * Copyright (c) 2005, 2007 CodeSourcery.
 | |
|  * Copyright (c) 2019, 2022 Linaro
 | |
|  *
 | |
|  * SPDX-License-Identifier: GPL-2.0-or-later
 | |
|  */
 | |
| 
 | |
| #ifndef TARGET_ARM_COMMON_SEMI_TARGET_H
 | |
| #define TARGET_ARM_COMMON_SEMI_TARGET_H
 | |
| 
 | |
| #include "target/arm/cpu-qom.h"
 | |
| 
 | |
| static inline target_ulong common_semi_arg(CPUState *cs, int argno)
 | |
| {
 | |
|     ARMCPU *cpu = ARM_CPU(cs);
 | |
|     CPUARMState *env = &cpu->env;
 | |
|     if (is_a64(env)) {
 | |
|         return env->xregs[argno];
 | |
|     } else {
 | |
|         return env->regs[argno];
 | |
|     }
 | |
| }
 | |
| 
 | |
| static inline void common_semi_set_ret(CPUState *cs, target_ulong ret)
 | |
| {
 | |
|     ARMCPU *cpu = ARM_CPU(cs);
 | |
|     CPUARMState *env = &cpu->env;
 | |
|     if (is_a64(env)) {
 | |
|         env->xregs[0] = ret;
 | |
|     } else {
 | |
|         env->regs[0] = ret;
 | |
|     }
 | |
| }
 | |
| 
 | |
| static inline bool common_semi_sys_exit_extended(CPUState *cs, int nr)
 | |
| {
 | |
|     return nr == TARGET_SYS_EXIT_EXTENDED || is_a64(cpu_env(cs));
 | |
| }
 | |
| 
 | |
| static inline bool is_64bit_semihosting(CPUArchState *env)
 | |
| {
 | |
|     return is_a64(env);
 | |
| }
 | |
| 
 | |
| static inline target_ulong common_semi_stack_bottom(CPUState *cs)
 | |
| {
 | |
|     ARMCPU *cpu = ARM_CPU(cs);
 | |
|     CPUARMState *env = &cpu->env;
 | |
|     return is_a64(env) ? env->xregs[31] : env->regs[13];
 | |
| }
 | |
| 
 | |
| static inline bool common_semi_has_synccache(CPUArchState *env)
 | |
| {
 | |
|     /* Ok for A64, invalid for A32/T32 */
 | |
|     return is_a64(env);
 | |
| }
 | |
| 
 | |
| #endif
 |