 70a54b0169
			
		
	
	
		70a54b0169
		
	
	
	
	
		
			
			With latest clang 13.0.0 we get
../ui/clipboard.c:47:34: error: variable 'old' set but not used [-Werror,-Wunused-but-set-variable]
    g_autoptr(QemuClipboardInfo) old = NULL;
                                 ^
The compiler can't tell that we only declared this variable in
order to get the side effect of free'ing it when out of scope.
This pattern is a little dubious for a use of g_autoptr, so
rewrite the code to avoid it.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
[AJB: fix merge conflict]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-2-berrange@redhat.com>
Message-Id: <20220105135009.1584676-2-alex.bennee@linaro.org>
		
	
			
		
			
				
	
	
		
			158 lines
		
	
	
		
			3.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			158 lines
		
	
	
		
			3.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| #include "qemu/osdep.h"
 | |
| #include "ui/clipboard.h"
 | |
| 
 | |
| static NotifierList clipboard_notifiers =
 | |
|     NOTIFIER_LIST_INITIALIZER(clipboard_notifiers);
 | |
| 
 | |
| static QemuClipboardInfo *cbinfo[QEMU_CLIPBOARD_SELECTION__COUNT];
 | |
| 
 | |
| void qemu_clipboard_peer_register(QemuClipboardPeer *peer)
 | |
| {
 | |
|     notifier_list_add(&clipboard_notifiers, &peer->notifier);
 | |
| }
 | |
| 
 | |
| void qemu_clipboard_peer_unregister(QemuClipboardPeer *peer)
 | |
| {
 | |
|     int i;
 | |
| 
 | |
|     for (i = 0; i < QEMU_CLIPBOARD_SELECTION__COUNT; i++) {
 | |
|         qemu_clipboard_peer_release(peer, i);
 | |
|     }
 | |
|     notifier_remove(&peer->notifier);
 | |
| }
 | |
| 
 | |
| bool qemu_clipboard_peer_owns(QemuClipboardPeer *peer,
 | |
|                               QemuClipboardSelection selection)
 | |
| {
 | |
|     QemuClipboardInfo *info = qemu_clipboard_info(selection);
 | |
| 
 | |
|     return info && info->owner == peer;
 | |
| }
 | |
| 
 | |
| void qemu_clipboard_peer_release(QemuClipboardPeer *peer,
 | |
|                                  QemuClipboardSelection selection)
 | |
| {
 | |
|     g_autoptr(QemuClipboardInfo) info = NULL;
 | |
| 
 | |
|     if (qemu_clipboard_peer_owns(peer, selection)) {
 | |
|         /* set empty clipboard info */
 | |
|         info = qemu_clipboard_info_new(NULL, selection);
 | |
|         qemu_clipboard_update(info);
 | |
|     }
 | |
| }
 | |
| 
 | |
| bool qemu_clipboard_check_serial(QemuClipboardInfo *info, bool client)
 | |
| {
 | |
|     if (!info->has_serial ||
 | |
|         !cbinfo[info->selection] ||
 | |
|         !cbinfo[info->selection]->has_serial) {
 | |
|         return true;
 | |
|     }
 | |
| 
 | |
|     if (client) {
 | |
|         return cbinfo[info->selection]->serial >= info->serial;
 | |
|     } else {
 | |
|         return cbinfo[info->selection]->serial > info->serial;
 | |
|     }
 | |
| }
 | |
| 
 | |
| void qemu_clipboard_update(QemuClipboardInfo *info)
 | |
| {
 | |
|     QemuClipboardNotify notify = {
 | |
|         .type = QEMU_CLIPBOARD_UPDATE_INFO,
 | |
|         .info = info,
 | |
|     };
 | |
|     assert(info->selection < QEMU_CLIPBOARD_SELECTION__COUNT);
 | |
| 
 | |
|     notifier_list_notify(&clipboard_notifiers, ¬ify);
 | |
| 
 | |
|     qemu_clipboard_info_unref(cbinfo[info->selection]);
 | |
|     cbinfo[info->selection] = qemu_clipboard_info_ref(info);
 | |
| }
 | |
| 
 | |
| QemuClipboardInfo *qemu_clipboard_info(QemuClipboardSelection selection)
 | |
| {
 | |
|     assert(selection < QEMU_CLIPBOARD_SELECTION__COUNT);
 | |
| 
 | |
|     return cbinfo[selection];
 | |
| }
 | |
| 
 | |
| QemuClipboardInfo *qemu_clipboard_info_new(QemuClipboardPeer *owner,
 | |
|                                            QemuClipboardSelection selection)
 | |
| {
 | |
|     QemuClipboardInfo *info = g_new0(QemuClipboardInfo, 1);
 | |
| 
 | |
|     info->owner = owner;
 | |
|     info->selection = selection;
 | |
|     info->refcount = 1;
 | |
| 
 | |
|     return info;
 | |
| }
 | |
| 
 | |
| QemuClipboardInfo *qemu_clipboard_info_ref(QemuClipboardInfo *info)
 | |
| {
 | |
|     info->refcount++;
 | |
|     return info;
 | |
| }
 | |
| 
 | |
| void qemu_clipboard_info_unref(QemuClipboardInfo *info)
 | |
| {
 | |
|     uint32_t type;
 | |
| 
 | |
|     if (!info) {
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     info->refcount--;
 | |
|     if (info->refcount > 0) {
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     for (type = 0; type < QEMU_CLIPBOARD_TYPE__COUNT; type++) {
 | |
|         g_free(info->types[type].data);
 | |
|     }
 | |
|     g_free(info);
 | |
| }
 | |
| 
 | |
| void qemu_clipboard_request(QemuClipboardInfo *info,
 | |
|                             QemuClipboardType type)
 | |
| {
 | |
|     if (info->types[type].data ||
 | |
|         info->types[type].requested ||
 | |
|         !info->types[type].available ||
 | |
|         !info->owner)
 | |
|         return;
 | |
| 
 | |
|     info->types[type].requested = true;
 | |
|     info->owner->request(info, type);
 | |
| }
 | |
| 
 | |
| void qemu_clipboard_reset_serial(void)
 | |
| {
 | |
|     QemuClipboardNotify notify = { .type = QEMU_CLIPBOARD_RESET_SERIAL };
 | |
| 
 | |
|     notifier_list_notify(&clipboard_notifiers, ¬ify);
 | |
| }
 | |
| 
 | |
| void qemu_clipboard_set_data(QemuClipboardPeer *peer,
 | |
|                              QemuClipboardInfo *info,
 | |
|                              QemuClipboardType type,
 | |
|                              uint32_t size,
 | |
|                              const void *data,
 | |
|                              bool update)
 | |
| {
 | |
|     if (!info ||
 | |
|         info->owner != peer) {
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     g_free(info->types[type].data);
 | |
|     info->types[type].data = g_memdup(data, size);
 | |
|     info->types[type].size = size;
 | |
|     info->types[type].available = true;
 | |
| 
 | |
|     if (update) {
 | |
|         qemu_clipboard_update(info);
 | |
|     }
 | |
| }
 |