In my "build everything" tree, changing hw/qdev-properties.h triggers a recompile of some 2700 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). Many places including hw/qdev-properties.h (directly or via hw/qdev.h) actually need only hw/qdev-core.h. Include hw/qdev-core.h there instead. hw/qdev.h is actually pointless: all it does is include hw/qdev-core.h and hw/qdev-properties.h, which in turn includes hw/qdev-core.h. Replace the remaining uses of hw/qdev.h by hw/qdev-properties.h. While there, delete a few superfluous inclusions of hw/qdev-core.h. Touching hw/qdev-properties.h now recompiles some 1200 objects. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: "Daniel P. Berrangé" <berrange@redhat.com> Cc: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20190812052359.30071-22-armbru@redhat.com>
		
			
				
	
	
		
			106 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			106 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Vhost user scsi PCI Bindings
 | 
						|
 *
 | 
						|
 * Copyright (c) 2016 Nutanix Inc. All rights reserved.
 | 
						|
 *
 | 
						|
 * Author:
 | 
						|
 *  Felipe Franciosi <felipe@nutanix.com>
 | 
						|
 *
 | 
						|
 * This work is largely based on the "vhost-scsi" implementation by:
 | 
						|
 *  Stefan Hajnoczi    <stefanha@linux.vnet.ibm.com>
 | 
						|
 *  Nicholas Bellinger <nab@risingtidesystems.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU LGPL, version 2 or later.
 | 
						|
 * See the COPYING.LIB file in the top-level directory.
 | 
						|
 *
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
 | 
						|
#include "standard-headers/linux/virtio_pci.h"
 | 
						|
#include "hw/virtio/vhost-user-scsi.h"
 | 
						|
#include "hw/virtio/virtio.h"
 | 
						|
#include "hw/virtio/virtio-scsi.h"
 | 
						|
#include "hw/pci/pci.h"
 | 
						|
#include "hw/qdev-properties.h"
 | 
						|
#include "qapi/error.h"
 | 
						|
#include "qemu/error-report.h"
 | 
						|
#include "qemu/module.h"
 | 
						|
#include "hw/pci/msi.h"
 | 
						|
#include "hw/pci/msix.h"
 | 
						|
#include "hw/loader.h"
 | 
						|
#include "sysemu/kvm.h"
 | 
						|
#include "virtio-pci.h"
 | 
						|
 | 
						|
typedef struct VHostUserSCSIPCI VHostUserSCSIPCI;
 | 
						|
 | 
						|
#define TYPE_VHOST_USER_SCSI_PCI "vhost-user-scsi-pci-base"
 | 
						|
#define VHOST_USER_SCSI_PCI(obj) \
 | 
						|
        OBJECT_CHECK(VHostUserSCSIPCI, (obj), TYPE_VHOST_USER_SCSI_PCI)
 | 
						|
 | 
						|
struct VHostUserSCSIPCI {
 | 
						|
    VirtIOPCIProxy parent_obj;
 | 
						|
    VHostUserSCSI vdev;
 | 
						|
};
 | 
						|
 | 
						|
static Property vhost_user_scsi_pci_properties[] = {
 | 
						|
    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors,
 | 
						|
                       DEV_NVECTORS_UNSPECIFIED),
 | 
						|
    DEFINE_PROP_END_OF_LIST(),
 | 
						|
};
 | 
						|
 | 
						|
static void vhost_user_scsi_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
 | 
						|
{
 | 
						|
    VHostUserSCSIPCI *dev = VHOST_USER_SCSI_PCI(vpci_dev);
 | 
						|
    DeviceState *vdev = DEVICE(&dev->vdev);
 | 
						|
    VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(vdev);
 | 
						|
 | 
						|
    if (vpci_dev->nvectors == DEV_NVECTORS_UNSPECIFIED) {
 | 
						|
        vpci_dev->nvectors = vs->conf.num_queues + 3;
 | 
						|
    }
 | 
						|
 | 
						|
    qdev_set_parent_bus(vdev, BUS(&vpci_dev->bus));
 | 
						|
    object_property_set_bool(OBJECT(vdev), true, "realized", errp);
 | 
						|
}
 | 
						|
 | 
						|
static void vhost_user_scsi_pci_class_init(ObjectClass *klass, void *data)
 | 
						|
{
 | 
						|
    DeviceClass *dc = DEVICE_CLASS(klass);
 | 
						|
    VirtioPCIClass *k = VIRTIO_PCI_CLASS(klass);
 | 
						|
    PCIDeviceClass *pcidev_k = PCI_DEVICE_CLASS(klass);
 | 
						|
    k->realize = vhost_user_scsi_pci_realize;
 | 
						|
    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
 | 
						|
    dc->props = vhost_user_scsi_pci_properties;
 | 
						|
    pcidev_k->vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET;
 | 
						|
    pcidev_k->device_id = PCI_DEVICE_ID_VIRTIO_SCSI;
 | 
						|
    pcidev_k->revision = 0x00;
 | 
						|
    pcidev_k->class_id = PCI_CLASS_STORAGE_SCSI;
 | 
						|
}
 | 
						|
 | 
						|
static void vhost_user_scsi_pci_instance_init(Object *obj)
 | 
						|
{
 | 
						|
    VHostUserSCSIPCI *dev = VHOST_USER_SCSI_PCI(obj);
 | 
						|
 | 
						|
    virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
 | 
						|
                                TYPE_VHOST_USER_SCSI);
 | 
						|
    object_property_add_alias(obj, "bootindex", OBJECT(&dev->vdev),
 | 
						|
                              "bootindex", &error_abort);
 | 
						|
}
 | 
						|
 | 
						|
static const VirtioPCIDeviceTypeInfo vhost_user_scsi_pci_info = {
 | 
						|
    .base_name             = TYPE_VHOST_USER_SCSI_PCI,
 | 
						|
    .generic_name          = "vhost-user-scsi-pci",
 | 
						|
    .transitional_name     = "vhost-user-scsi-pci-transitional",
 | 
						|
    .non_transitional_name = "vhost-user-scsi-pci-non-transitional",
 | 
						|
    .instance_size = sizeof(VHostUserSCSIPCI),
 | 
						|
    .instance_init = vhost_user_scsi_pci_instance_init,
 | 
						|
    .class_init    = vhost_user_scsi_pci_class_init,
 | 
						|
};
 | 
						|
 | 
						|
static void vhost_user_scsi_pci_register(void)
 | 
						|
{
 | 
						|
    virtio_pci_types_register(&vhost_user_scsi_pci_info);
 | 
						|
}
 | 
						|
 | 
						|
type_init(vhost_user_scsi_pci_register)
 |