In my "build everything" tree, changing hw/qdev-properties.h triggers a recompile of some 2700 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). Many places including hw/qdev-properties.h (directly or via hw/qdev.h) actually need only hw/qdev-core.h. Include hw/qdev-core.h there instead. hw/qdev.h is actually pointless: all it does is include hw/qdev-core.h and hw/qdev-properties.h, which in turn includes hw/qdev-core.h. Replace the remaining uses of hw/qdev.h by hw/qdev-properties.h. While there, delete a few superfluous inclusions of hw/qdev-core.h. Touching hw/qdev-properties.h now recompiles some 1200 objects. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: "Daniel P. Berrangé" <berrange@redhat.com> Cc: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20190812052359.30071-22-armbru@redhat.com>
		
			
				
	
	
		
			191 lines
		
	
	
		
			5.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			191 lines
		
	
	
		
			5.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * x3130_downstream.c
 | 
						|
 * TI X3130 pci express downstream port switch
 | 
						|
 *
 | 
						|
 * Copyright (c) 2010 Isaku Yamahata <yamahata at valinux co jp>
 | 
						|
 *                    VA Linux Systems Japan K.K.
 | 
						|
 *
 | 
						|
 * This program is free software; you can redistribute it and/or modify
 | 
						|
 * it under the terms of the GNU General Public License as published by
 | 
						|
 * the Free Software Foundation; either version 2 of the License, or
 | 
						|
 * (at your option) any later version.
 | 
						|
 *
 | 
						|
 * This program is distributed in the hope that it will be useful,
 | 
						|
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
 * GNU General Public License for more details.
 | 
						|
 *
 | 
						|
 * You should have received a copy of the GNU General Public License along
 | 
						|
 * with this program; if not, see <http://www.gnu.org/licenses/>.
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "hw/pci/pci_ids.h"
 | 
						|
#include "hw/pci/msi.h"
 | 
						|
#include "hw/pci/pcie.h"
 | 
						|
#include "hw/pci/pcie_port.h"
 | 
						|
#include "hw/qdev-properties.h"
 | 
						|
#include "migration/vmstate.h"
 | 
						|
#include "qapi/error.h"
 | 
						|
#include "qemu/module.h"
 | 
						|
 | 
						|
#define PCI_DEVICE_ID_TI_XIO3130D       0x8233  /* downstream port */
 | 
						|
#define XIO3130_REVISION                0x1
 | 
						|
#define XIO3130_MSI_OFFSET              0x70
 | 
						|
#define XIO3130_MSI_SUPPORTED_FLAGS     PCI_MSI_FLAGS_64BIT
 | 
						|
#define XIO3130_MSI_NR_VECTOR           1
 | 
						|
#define XIO3130_SSVID_OFFSET            0x80
 | 
						|
#define XIO3130_SSVID_SVID              0
 | 
						|
#define XIO3130_SSVID_SSID              0
 | 
						|
#define XIO3130_EXP_OFFSET              0x90
 | 
						|
#define XIO3130_AER_OFFSET              0x100
 | 
						|
 | 
						|
static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address,
 | 
						|
                                         uint32_t val, int len)
 | 
						|
{
 | 
						|
    uint16_t slt_ctl, slt_sta;
 | 
						|
 | 
						|
    pcie_cap_slot_get(d, &slt_ctl, &slt_sta);
 | 
						|
    pci_bridge_write_config(d, address, val, len);
 | 
						|
    pcie_cap_flr_write_config(d, address, val, len);
 | 
						|
    pcie_cap_slot_write_config(d, slt_ctl, slt_sta, address, val, len);
 | 
						|
    pcie_aer_write_config(d, address, val, len);
 | 
						|
}
 | 
						|
 | 
						|
static void xio3130_downstream_reset(DeviceState *qdev)
 | 
						|
{
 | 
						|
    PCIDevice *d = PCI_DEVICE(qdev);
 | 
						|
 | 
						|
    pcie_cap_deverr_reset(d);
 | 
						|
    pcie_cap_slot_reset(d);
 | 
						|
    pcie_cap_arifwd_reset(d);
 | 
						|
    pci_bridge_reset(qdev);
 | 
						|
}
 | 
						|
 | 
						|
static void xio3130_downstream_realize(PCIDevice *d, Error **errp)
 | 
						|
{
 | 
						|
    PCIEPort *p = PCIE_PORT(d);
 | 
						|
    PCIESlot *s = PCIE_SLOT(d);
 | 
						|
    int rc;
 | 
						|
 | 
						|
    pci_bridge_initfn(d, TYPE_PCIE_BUS);
 | 
						|
    pcie_port_init_reg(d);
 | 
						|
 | 
						|
    rc = msi_init(d, XIO3130_MSI_OFFSET, XIO3130_MSI_NR_VECTOR,
 | 
						|
                  XIO3130_MSI_SUPPORTED_FLAGS & PCI_MSI_FLAGS_64BIT,
 | 
						|
                  XIO3130_MSI_SUPPORTED_FLAGS & PCI_MSI_FLAGS_MASKBIT,
 | 
						|
                  errp);
 | 
						|
    if (rc < 0) {
 | 
						|
        assert(rc == -ENOTSUP);
 | 
						|
        goto err_bridge;
 | 
						|
    }
 | 
						|
 | 
						|
    rc = pci_bridge_ssvid_init(d, XIO3130_SSVID_OFFSET,
 | 
						|
                               XIO3130_SSVID_SVID, XIO3130_SSVID_SSID,
 | 
						|
                               errp);
 | 
						|
    if (rc < 0) {
 | 
						|
        goto err_bridge;
 | 
						|
    }
 | 
						|
 | 
						|
    rc = pcie_cap_init(d, XIO3130_EXP_OFFSET, PCI_EXP_TYPE_DOWNSTREAM,
 | 
						|
                       p->port, errp);
 | 
						|
    if (rc < 0) {
 | 
						|
        goto err_msi;
 | 
						|
    }
 | 
						|
    pcie_cap_flr_init(d);
 | 
						|
    pcie_cap_deverr_init(d);
 | 
						|
    pcie_cap_slot_init(d, s->slot);
 | 
						|
    pcie_cap_arifwd_init(d);
 | 
						|
 | 
						|
    pcie_chassis_create(s->chassis);
 | 
						|
    rc = pcie_chassis_add_slot(s);
 | 
						|
    if (rc < 0) {
 | 
						|
        error_setg(errp, "Can't add chassis slot, error %d", rc);
 | 
						|
        goto err_pcie_cap;
 | 
						|
    }
 | 
						|
 | 
						|
    rc = pcie_aer_init(d, PCI_ERR_VER, XIO3130_AER_OFFSET,
 | 
						|
                       PCI_ERR_SIZEOF, errp);
 | 
						|
    if (rc < 0) {
 | 
						|
        goto err;
 | 
						|
    }
 | 
						|
 | 
						|
    return;
 | 
						|
 | 
						|
err:
 | 
						|
    pcie_chassis_del_slot(s);
 | 
						|
err_pcie_cap:
 | 
						|
    pcie_cap_exit(d);
 | 
						|
err_msi:
 | 
						|
    msi_uninit(d);
 | 
						|
err_bridge:
 | 
						|
    pci_bridge_exitfn(d);
 | 
						|
}
 | 
						|
 | 
						|
static void xio3130_downstream_exitfn(PCIDevice *d)
 | 
						|
{
 | 
						|
    PCIESlot *s = PCIE_SLOT(d);
 | 
						|
 | 
						|
    pcie_aer_exit(d);
 | 
						|
    pcie_chassis_del_slot(s);
 | 
						|
    pcie_cap_exit(d);
 | 
						|
    msi_uninit(d);
 | 
						|
    pci_bridge_exitfn(d);
 | 
						|
}
 | 
						|
 | 
						|
static Property xio3130_downstream_props[] = {
 | 
						|
    DEFINE_PROP_BIT(COMPAT_PROP_PCP, PCIDevice, cap_present,
 | 
						|
                    QEMU_PCIE_SLTCAP_PCP_BITNR, true),
 | 
						|
    DEFINE_PROP_END_OF_LIST()
 | 
						|
};
 | 
						|
 | 
						|
static const VMStateDescription vmstate_xio3130_downstream = {
 | 
						|
    .name = "xio3130-express-downstream-port",
 | 
						|
    .priority = MIG_PRI_PCI_BUS,
 | 
						|
    .version_id = 1,
 | 
						|
    .minimum_version_id = 1,
 | 
						|
    .post_load = pcie_cap_slot_post_load,
 | 
						|
    .fields = (VMStateField[]) {
 | 
						|
        VMSTATE_PCI_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot),
 | 
						|
        VMSTATE_STRUCT(parent_obj.parent_obj.parent_obj.exp.aer_log,
 | 
						|
                       PCIESlot, 0, vmstate_pcie_aer_log, PCIEAERLog),
 | 
						|
        VMSTATE_END_OF_LIST()
 | 
						|
    }
 | 
						|
};
 | 
						|
 | 
						|
static void xio3130_downstream_class_init(ObjectClass *klass, void *data)
 | 
						|
{
 | 
						|
    DeviceClass *dc = DEVICE_CLASS(klass);
 | 
						|
    PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
 | 
						|
 | 
						|
    k->is_bridge = true;
 | 
						|
    k->config_write = xio3130_downstream_write_config;
 | 
						|
    k->realize = xio3130_downstream_realize;
 | 
						|
    k->exit = xio3130_downstream_exitfn;
 | 
						|
    k->vendor_id = PCI_VENDOR_ID_TI;
 | 
						|
    k->device_id = PCI_DEVICE_ID_TI_XIO3130D;
 | 
						|
    k->revision = XIO3130_REVISION;
 | 
						|
    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
 | 
						|
    dc->desc = "TI X3130 Downstream Port of PCI Express Switch";
 | 
						|
    dc->reset = xio3130_downstream_reset;
 | 
						|
    dc->vmsd = &vmstate_xio3130_downstream;
 | 
						|
    dc->props = xio3130_downstream_props;
 | 
						|
}
 | 
						|
 | 
						|
static const TypeInfo xio3130_downstream_info = {
 | 
						|
    .name          = "xio3130-downstream",
 | 
						|
    .parent        = TYPE_PCIE_SLOT,
 | 
						|
    .class_init    = xio3130_downstream_class_init,
 | 
						|
    .interfaces = (InterfaceInfo[]) {
 | 
						|
        { INTERFACE_PCIE_DEVICE },
 | 
						|
        { }
 | 
						|
    },
 | 
						|
};
 | 
						|
 | 
						|
static void xio3130_downstream_register_types(void)
 | 
						|
{
 | 
						|
    type_register_static(&xio3130_downstream_info);
 | 
						|
}
 | 
						|
 | 
						|
type_init(xio3130_downstream_register_types)
 |