SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
FRET-qemu/hw/virtio
History
Stefan Hajnoczi b7c1bd9d78 Revert "vhost-blk: set features before setting inflight feature" 
This reverts commit adb29c027341ba095a3ef4beef6aaef86d3a520e.

The commit broke -device vhost-user-blk-pci because the
vhost_dev_prepare_inflight() function it introduced segfaults in
vhost_dev_set_features() when attempting to access struct vhost_dev's
vdev pointer before it has been assigned.

To reproduce the segfault simply launch a vhost-user-blk device with the
contrib vhost-user-blk device backend:

  $ build/contrib/vhost-user-blk/vhost-user-blk -s /tmp/vhost-user-blk.sock -r -b /var/tmp/foo.img
  $ build/qemu-system-x86_64 \
        -device vhost-user-blk-pci,id=drv0,chardev=char1,addr=4.0 \
        -object memory-backend-memfd,id=mem,size=1G,share=on \
        -M memory-backend=mem,accel=kvm \
        -chardev socket,id=char1,path=/tmp/vhost-user-blk.sock
  Segmentation fault (core dumped)

Cc: Jin Yu <jin.yu@intel.com>
Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20201102165709.232180-1-stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2020-11-03 16:39:05 -05:00
..
Kconfig
virtio-mem: Paravirtualized memory hot(un)plug
2020-07-03 07:57:04 -04:00
meson.build
meson: convert hw/virtio
2020-08-21 06:30:26 -04:00
trace-events
virtio-iommu: Set supported page size mask
2020-11-03 07:19:27 -05:00
trace.h
trace: switch position of headers to what Meson requires
2020-08-21 06:18:24 -04:00
vhost-backend.c
hw/virtio/vhost-backend: Fix Coverity CID 1432871
2020-11-03 07:19:27 -05:00
vhost-scsi-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
vhost-stub.c
vhost-user: simplify vhost_user_init/vhost_user_cleanup
2019-03-12 21:22:31 -04:00
vhost-user-blk-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
vhost-user-fs-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
vhost-user-fs.c
qdev: Unrealize must not fail
2020-05-15 07:08:14 +02:00
vhost-user-input-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
vhost-user-scsi-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
vhost-user-vsock-pci.c
vhost-user-vsock-pci: force virtio version 1
2020-09-29 02:15:24 -04:00
vhost-user-vsock.c
virtio: add vhost-user-vsock base device
2020-06-12 10:17:06 -04:00
vhost-user.c
hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions()
2020-09-01 11:58:32 +02:00
vhost-vdpa.c
hw/virtio/vhost-vdpa: Fix Coverity CID 1432864
2020-10-30 04:29:13 -04:00
vhost-vsock-common.c
vhost-vsock: add vhost-vsock-common abstraction
2020-06-12 10:17:06 -04:00
vhost-vsock-pci.c
vhost-vsock-pci: force virtio version 1
2020-09-29 02:15:24 -04:00
vhost-vsock.c
vhost-vsock: set vhostfd to non-blocking mode
2020-10-30 04:29:13 -04:00
vhost.c
Revert "vhost-blk: set features before setting inflight feature"
2020-11-03 16:39:05 -05:00
virtio-9p-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio-balloon-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio-balloon.c
qapi: Restrict balloon-related commands to machine code
2020-09-29 15:41:35 +02:00
virtio-blk-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio-bus.c
virtio: notify virtqueue via host notifier when available
2019-11-06 06:35:00 -05:00
virtio-crypto-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio-crypto.c
virtio-crypto: don't modify elem->in/out_sg
2020-09-23 13:41:58 +01:00
virtio-input-host-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio-input-pci.c
Use OBJECT_DECLARE_SIMPLE_TYPE when possible
2020-09-18 14:12:32 -04:00
virtio-iommu-pci.c
virtio-iommu-pci: force virtio version 1
2020-09-29 02:14:30 -04:00
virtio-iommu.c
virtio-iommu: Set supported page size mask
2020-11-03 07:19:27 -05:00
virtio-mem-pci.c
virito-mem: Implement get_min_alignment()
2020-11-03 07:19:26 -05:00
virtio-mem-pci.h
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio-mem.c
virtio-mem: Probe THP size to determine default block size
2020-11-03 07:19:26 -05:00
virtio-mmio.c
qemu/atomic.h: rename atomic_ to qatomic_
2020-09-23 16:07:44 +01:00
virtio-net-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio-pci.c
virtio: skip legacy support check on machine types less than 5.1
2020-09-29 02:15:24 -04:00
virtio-pci.h
Use OBJECT_DECLARE_TYPE when possible
2020-09-18 14:12:32 -04:00
virtio-pmem-pci.c
virtio-pmem-pci: force virtio version 1
2020-09-29 02:14:30 -04:00
virtio-pmem-pci.h
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio-pmem.c
hw: virtio-pmem: detach the element fromt the virtqueue when error occurs
2020-09-29 03:06:12 -04:00
virtio-rng-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio-rng.c
error: Eliminate error_propagate() with Coccinelle, part 1
2020-07-10 15:18:08 +02:00
virtio-scsi-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio-serial-pci.c
Use DECLARE_*CHECKER* macros
2020-09-09 09:27:09 -04:00
virtio.c
virtio: skip guest index check on device load
2020-10-30 06:48:53 -04:00