load_dtb() depends on arm_load_kernel() to figure out place in RAM where it should be loaded, but it's not required for arm_load_kernel() to work. Sometimes it's neccesary for devices added with -device/device_add to be enumerated in DTB as well, which's lead to [1] and surrounding commits to add 2 more machine_done notifiers with non obvious ordering to make dynamic sysbus devices initialization happen in the right order. However instead of moving whole arm_load_kernel() in to machine_done, it's sufficient to move only load_dtb() into virt_machine_done() notifier and remove ArmLoadKernelNotifier/ /PlatformBusFDTNotifierParams notifiers, which saves us ~90LOC and simplifies code flow quite a bit. Later would allow to consolidate DTB generation within one function for 'mach-virt' board and make it reentrant so it could generate updated DTB in device hotplug secenarios. While at it rename load_dtb() to arm_load_dtb() since it's public now. Add additional field skip_dtb_autoload to struct arm_boot_info to allow manual DTB load later in mach-virt and to avoid touching all other boards to explicitly call arm_load_dtb(). 1) (ac9d32e hw/arm/boot: arm_load_kernel implemented as a machine init done notifier) Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Andrew Jones <drjones@redhat.com> Message-id: 1525691524-32265-4-git-send-email-imammedo@redhat.com Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
		
			
				
	
	
		
			179 lines
		
	
	
		
			6.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			179 lines
		
	
	
		
			6.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Misc ARM declarations
 | 
						|
 *
 | 
						|
 * Copyright (c) 2006 CodeSourcery.
 | 
						|
 * Written by Paul Brook
 | 
						|
 *
 | 
						|
 * This code is licensed under the LGPL.
 | 
						|
 *
 | 
						|
 */
 | 
						|
 | 
						|
#ifndef HW_ARM_H
 | 
						|
#define HW_ARM_H
 | 
						|
 | 
						|
#include "exec/memory.h"
 | 
						|
#include "target/arm/cpu-qom.h"
 | 
						|
#include "hw/irq.h"
 | 
						|
#include "qemu/notify.h"
 | 
						|
 | 
						|
typedef enum {
 | 
						|
    ARM_ENDIANNESS_UNKNOWN = 0,
 | 
						|
    ARM_ENDIANNESS_LE,
 | 
						|
    ARM_ENDIANNESS_BE8,
 | 
						|
    ARM_ENDIANNESS_BE32,
 | 
						|
} arm_endianness;
 | 
						|
 | 
						|
/* armv7m.c */
 | 
						|
DeviceState *armv7m_init(MemoryRegion *system_memory, int mem_size, int num_irq,
 | 
						|
                         const char *kernel_filename, const char *cpu_type);
 | 
						|
/**
 | 
						|
 * armv7m_load_kernel:
 | 
						|
 * @cpu: CPU
 | 
						|
 * @kernel_filename: file to load
 | 
						|
 * @mem_size: mem_size: maximum image size to load
 | 
						|
 *
 | 
						|
 * Load the guest image for an ARMv7M system. This must be called by
 | 
						|
 * any ARMv7M board, either directly or via armv7m_init(). (This is
 | 
						|
 * necessary to ensure that the CPU resets correctly on system reset,
 | 
						|
 * as well as for kernel loading.)
 | 
						|
 */
 | 
						|
void armv7m_load_kernel(ARMCPU *cpu, const char *kernel_filename, int mem_size);
 | 
						|
 | 
						|
/* arm_boot.c */
 | 
						|
struct arm_boot_info {
 | 
						|
    uint64_t ram_size;
 | 
						|
    const char *kernel_filename;
 | 
						|
    const char *kernel_cmdline;
 | 
						|
    const char *initrd_filename;
 | 
						|
    const char *dtb_filename;
 | 
						|
    hwaddr loader_start;
 | 
						|
    hwaddr dtb_start;
 | 
						|
    hwaddr dtb_limit;
 | 
						|
    /* If set to True, arm_load_kernel() will not load DTB.
 | 
						|
     * It allows board to load DTB manually later.
 | 
						|
     * (default: False)
 | 
						|
     */
 | 
						|
    bool skip_dtb_autoload;
 | 
						|
    /* multicore boards that use the default secondary core boot functions
 | 
						|
     * need to put the address of the secondary boot code, the boot reg,
 | 
						|
     * and the GIC address in the next 3 values, respectively. boards that
 | 
						|
     * have their own boot functions can use these values as they want.
 | 
						|
     */
 | 
						|
    hwaddr smp_loader_start;
 | 
						|
    hwaddr smp_bootreg_addr;
 | 
						|
    hwaddr gic_cpu_if_addr;
 | 
						|
    int nb_cpus;
 | 
						|
    int board_id;
 | 
						|
    /* ARM machines that support the ARM Security Extensions use this field to
 | 
						|
     * control whether Linux is booted as secure(true) or non-secure(false).
 | 
						|
     */
 | 
						|
    bool secure_boot;
 | 
						|
    int (*atag_board)(const struct arm_boot_info *info, void *p);
 | 
						|
    /* multicore boards that use the default secondary core boot functions
 | 
						|
     * can ignore these two function calls. If the default functions won't
 | 
						|
     * work, then write_secondary_boot() should write a suitable blob of
 | 
						|
     * code mimicking the secondary CPU startup process used by the board's
 | 
						|
     * boot loader/boot ROM code, and secondary_cpu_reset_hook() should
 | 
						|
     * perform any necessary CPU reset handling and set the PC for the
 | 
						|
     * secondary CPUs to point at this boot blob.
 | 
						|
     */
 | 
						|
    void (*write_secondary_boot)(ARMCPU *cpu,
 | 
						|
                                 const struct arm_boot_info *info);
 | 
						|
    void (*secondary_cpu_reset_hook)(ARMCPU *cpu,
 | 
						|
                                     const struct arm_boot_info *info);
 | 
						|
    /* if a board is able to create a dtb without a dtb file then it
 | 
						|
     * sets get_dtb. This will only be used if no dtb file is provided
 | 
						|
     * by the user. On success, sets *size to the length of the created
 | 
						|
     * dtb, and returns a pointer to it. (The caller must free this memory
 | 
						|
     * with g_free() when it has finished with it.) On failure, returns NULL.
 | 
						|
     */
 | 
						|
    void *(*get_dtb)(const struct arm_boot_info *info, int *size);
 | 
						|
    /* if a board needs to be able to modify a device tree provided by
 | 
						|
     * the user it should implement this hook.
 | 
						|
     */
 | 
						|
    void (*modify_dtb)(const struct arm_boot_info *info, void *fdt);
 | 
						|
    /* Used internally by arm_boot.c */
 | 
						|
    int is_linux;
 | 
						|
    hwaddr initrd_start;
 | 
						|
    hwaddr initrd_size;
 | 
						|
    hwaddr entry;
 | 
						|
 | 
						|
    /* Boot firmware has been loaded, typically at address 0, with -bios or
 | 
						|
     * -pflash. It also implies that fw_cfg_find() will succeed.
 | 
						|
     */
 | 
						|
    bool firmware_loaded;
 | 
						|
 | 
						|
    /* Address at which board specific loader/setup code exists. If enabled,
 | 
						|
     * this code-blob will run before anything else. It must return to the
 | 
						|
     * caller via the link register. There is no stack set up. Enabled by
 | 
						|
     * defining write_board_setup, which is responsible for loading the blob
 | 
						|
     * to the specified address.
 | 
						|
     */
 | 
						|
    hwaddr board_setup_addr;
 | 
						|
    void (*write_board_setup)(ARMCPU *cpu,
 | 
						|
                              const struct arm_boot_info *info);
 | 
						|
 | 
						|
    /* If set, the board specific loader/setup blob will be run from secure
 | 
						|
     * mode, regardless of secure_boot. The blob becomes responsible for
 | 
						|
     * changing to non-secure state if implementing a non-secure boot
 | 
						|
     */
 | 
						|
    bool secure_board_setup;
 | 
						|
 | 
						|
    arm_endianness endianness;
 | 
						|
};
 | 
						|
 | 
						|
/**
 | 
						|
 * arm_load_kernel - Loads memory with everything needed to boot
 | 
						|
 *
 | 
						|
 * @cpu: handle to the first CPU object
 | 
						|
 * @info: handle to the boot info struct
 | 
						|
 * Registers a machine init done notifier that copies to memory
 | 
						|
 * everything needed to boot, depending on machine and user options:
 | 
						|
 * kernel image, boot loaders, initrd, dtb. Also registers the CPU
 | 
						|
 * reset handler.
 | 
						|
 *
 | 
						|
 * In case the machine file supports the platform bus device and its
 | 
						|
 * dynamically instantiable sysbus devices, this function must be called
 | 
						|
 * before sysbus-fdt arm_register_platform_bus_fdt_creator. Indeed the
 | 
						|
 * machine init done notifiers are called in registration reverse order.
 | 
						|
 */
 | 
						|
void arm_load_kernel(ARMCPU *cpu, struct arm_boot_info *info);
 | 
						|
 | 
						|
AddressSpace *arm_boot_address_space(ARMCPU *cpu,
 | 
						|
                                     const struct arm_boot_info *info);
 | 
						|
 | 
						|
/**
 | 
						|
 * arm_load_dtb() - load a device tree binary image into memory
 | 
						|
 * @addr:       the address to load the image at
 | 
						|
 * @binfo:      struct describing the boot environment
 | 
						|
 * @addr_limit: upper limit of the available memory area at @addr
 | 
						|
 * @as:         address space to load image to
 | 
						|
 *
 | 
						|
 * Load a device tree supplied by the machine or by the user  with the
 | 
						|
 * '-dtb' command line option, and put it at offset @addr in target
 | 
						|
 * memory.
 | 
						|
 *
 | 
						|
 * If @addr_limit contains a meaningful value (i.e., it is strictly greater
 | 
						|
 * than @addr), the device tree is only loaded if its size does not exceed
 | 
						|
 * the limit.
 | 
						|
 *
 | 
						|
 * Returns: the size of the device tree image on success,
 | 
						|
 *          0 if the image size exceeds the limit,
 | 
						|
 *          -1 on errors.
 | 
						|
 *
 | 
						|
 * Note: Must not be called unless have_dtb(binfo) is true.
 | 
						|
 */
 | 
						|
int arm_load_dtb(hwaddr addr, const struct arm_boot_info *binfo,
 | 
						|
                 hwaddr addr_limit, AddressSpace *as);
 | 
						|
 | 
						|
/* Write a secure board setup routine with a dummy handler for SMCs */
 | 
						|
void arm_write_secure_board_setup_dummy_smc(ARMCPU *cpu,
 | 
						|
                                            const struct arm_boot_info *info,
 | 
						|
                                            hwaddr mvbar_addr);
 | 
						|
 | 
						|
/* Multiplication factor to convert from system clock ticks to qemu timer
 | 
						|
   ticks.  */
 | 
						|
extern int system_clock_scale;
 | 
						|
 | 
						|
#endif /* HW_ARM_H */
 |