 0c9390d978
			
		
	
	
		0c9390d978
		
	
	
	
	
		
			
			Back in qemu 2.5, qemu-nbd was immune to port probes (a transient
server would not quit, regardless of how many probe connections
came and went, until a connection actually negotiated).  But we
broke that in commit ee7d7aa when removing the return value to
nbd_client_new(), although that patch also introduced a bug causing
an assertion failure on a client that fails negotiation.  We then
made it worse during refactoring in commit 1a6245a (a segfault
before we could even assert); the (masked) assertion was cleaned
up in d3780c2 (still in 2.6), and just recently we finally fixed
the segfault ("nbd: Fully intialize client in case of failed
negotiation").  But that still means that ever since we added
TLS support to qemu-nbd, we have been vulnerable to an ill-timed
port-scan being able to cause a denial of service by taking down
qemu-nbd before a real client has a chance to connect.
Since negotiation is now handled asynchronously via coroutines,
we no longer have a synchronous point of return by re-adding a
return value to nbd_client_new().  So this patch instead wires
things up to pass the negotiation status through the close_fn
callback function.
Simple test across two terminals:
$ qemu-nbd -f raw -p 30001 file
$ nmap 127.0.0.1 -p 30001 && \
  qemu-io -c 'r 0 512' -f raw nbd://localhost:30001
Note that this patch does not change what constitutes successful
negotiation (thus, a client must enter transmission phase before
that client can be considered as a reason to terminate the server
when the connection ends).  Perhaps we may want to tweak things
in a later patch to also treat a client that uses NBD_OPT_ABORT
as being a 'successful' negotiation (the client correctly talked
the NBD protocol, and informed us it was not going to use our
export after all), but that's a discussion for another day.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1451614
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170608222617.20376-1-eblake@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
		
	
			
		
			
				
	
	
		
			213 lines
		
	
	
		
			5.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			213 lines
		
	
	
		
			5.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * Serving QEMU block devices via NBD
 | |
|  *
 | |
|  * Copyright (c) 2012 Red Hat, Inc.
 | |
|  *
 | |
|  * Author: Paolo Bonzini <pbonzini@redhat.com>
 | |
|  *
 | |
|  * This work is licensed under the terms of the GNU GPL, version 2 or
 | |
|  * later.  See the COPYING file in the top-level directory.
 | |
|  */
 | |
| 
 | |
| #include "qemu/osdep.h"
 | |
| #include "sysemu/blockdev.h"
 | |
| #include "sysemu/block-backend.h"
 | |
| #include "hw/block/block.h"
 | |
| #include "qapi/qmp/qerror.h"
 | |
| #include "sysemu/sysemu.h"
 | |
| #include "qmp-commands.h"
 | |
| #include "block/nbd.h"
 | |
| #include "io/channel-socket.h"
 | |
| 
 | |
| typedef struct NBDServerData {
 | |
|     QIOChannelSocket *listen_ioc;
 | |
|     int watch;
 | |
|     QCryptoTLSCreds *tlscreds;
 | |
| } NBDServerData;
 | |
| 
 | |
| static NBDServerData *nbd_server;
 | |
| 
 | |
| static void nbd_blockdev_client_closed(NBDClient *client, bool ignored)
 | |
| {
 | |
|     nbd_client_put(client);
 | |
| }
 | |
| 
 | |
| static gboolean nbd_accept(QIOChannel *ioc, GIOCondition condition,
 | |
|                            gpointer opaque)
 | |
| {
 | |
|     QIOChannelSocket *cioc;
 | |
| 
 | |
|     if (!nbd_server) {
 | |
|         return FALSE;
 | |
|     }
 | |
| 
 | |
|     cioc = qio_channel_socket_accept(QIO_CHANNEL_SOCKET(ioc),
 | |
|                                      NULL);
 | |
|     if (!cioc) {
 | |
|         return TRUE;
 | |
|     }
 | |
| 
 | |
|     qio_channel_set_name(QIO_CHANNEL(cioc), "nbd-server");
 | |
|     nbd_client_new(NULL, cioc,
 | |
|                    nbd_server->tlscreds, NULL,
 | |
|                    nbd_blockdev_client_closed);
 | |
|     object_unref(OBJECT(cioc));
 | |
|     return TRUE;
 | |
| }
 | |
| 
 | |
| 
 | |
| static void nbd_server_free(NBDServerData *server)
 | |
| {
 | |
|     if (!server) {
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     if (server->watch != -1) {
 | |
|         g_source_remove(server->watch);
 | |
|     }
 | |
|     object_unref(OBJECT(server->listen_ioc));
 | |
|     if (server->tlscreds) {
 | |
|         object_unref(OBJECT(server->tlscreds));
 | |
|     }
 | |
| 
 | |
|     g_free(server);
 | |
| }
 | |
| 
 | |
| static QCryptoTLSCreds *nbd_get_tls_creds(const char *id, Error **errp)
 | |
| {
 | |
|     Object *obj;
 | |
|     QCryptoTLSCreds *creds;
 | |
| 
 | |
|     obj = object_resolve_path_component(
 | |
|         object_get_objects_root(), id);
 | |
|     if (!obj) {
 | |
|         error_setg(errp, "No TLS credentials with id '%s'",
 | |
|                    id);
 | |
|         return NULL;
 | |
|     }
 | |
|     creds = (QCryptoTLSCreds *)
 | |
|         object_dynamic_cast(obj, TYPE_QCRYPTO_TLS_CREDS);
 | |
|     if (!creds) {
 | |
|         error_setg(errp, "Object with id '%s' is not TLS credentials",
 | |
|                    id);
 | |
|         return NULL;
 | |
|     }
 | |
| 
 | |
|     if (creds->endpoint != QCRYPTO_TLS_CREDS_ENDPOINT_SERVER) {
 | |
|         error_setg(errp,
 | |
|                    "Expecting TLS credentials with a server endpoint");
 | |
|         return NULL;
 | |
|     }
 | |
|     object_ref(obj);
 | |
|     return creds;
 | |
| }
 | |
| 
 | |
| 
 | |
| void nbd_server_start(SocketAddress *addr, const char *tls_creds,
 | |
|                       Error **errp)
 | |
| {
 | |
|     if (nbd_server) {
 | |
|         error_setg(errp, "NBD server already running");
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     nbd_server = g_new0(NBDServerData, 1);
 | |
|     nbd_server->watch = -1;
 | |
|     nbd_server->listen_ioc = qio_channel_socket_new();
 | |
|     qio_channel_set_name(QIO_CHANNEL(nbd_server->listen_ioc),
 | |
|                          "nbd-listener");
 | |
|     if (qio_channel_socket_listen_sync(
 | |
|             nbd_server->listen_ioc, addr, errp) < 0) {
 | |
|         goto error;
 | |
|     }
 | |
| 
 | |
|     if (tls_creds) {
 | |
|         nbd_server->tlscreds = nbd_get_tls_creds(tls_creds, errp);
 | |
|         if (!nbd_server->tlscreds) {
 | |
|             goto error;
 | |
|         }
 | |
| 
 | |
|         /* TODO SOCKET_ADDRESS_TYPE_FD where fd has AF_INET or AF_INET6 */
 | |
|         if (addr->type != SOCKET_ADDRESS_TYPE_INET) {
 | |
|             error_setg(errp, "TLS is only supported with IPv4/IPv6");
 | |
|             goto error;
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     nbd_server->watch = qio_channel_add_watch(
 | |
|         QIO_CHANNEL(nbd_server->listen_ioc),
 | |
|         G_IO_IN,
 | |
|         nbd_accept,
 | |
|         NULL,
 | |
|         NULL);
 | |
| 
 | |
|     return;
 | |
| 
 | |
|  error:
 | |
|     nbd_server_free(nbd_server);
 | |
|     nbd_server = NULL;
 | |
| }
 | |
| 
 | |
| void qmp_nbd_server_start(SocketAddressLegacy *addr,
 | |
|                           bool has_tls_creds, const char *tls_creds,
 | |
|                           Error **errp)
 | |
| {
 | |
|     SocketAddress *addr_flat = socket_address_flatten(addr);
 | |
| 
 | |
|     nbd_server_start(addr_flat, tls_creds, errp);
 | |
|     qapi_free_SocketAddress(addr_flat);
 | |
| }
 | |
| 
 | |
| void qmp_nbd_server_add(const char *device, bool has_writable, bool writable,
 | |
|                         Error **errp)
 | |
| {
 | |
|     BlockDriverState *bs = NULL;
 | |
|     BlockBackend *on_eject_blk;
 | |
|     NBDExport *exp;
 | |
| 
 | |
|     if (!nbd_server) {
 | |
|         error_setg(errp, "NBD server not running");
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     if (nbd_export_find(device)) {
 | |
|         error_setg(errp, "NBD server already exporting device '%s'", device);
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     on_eject_blk = blk_by_name(device);
 | |
| 
 | |
|     bs = bdrv_lookup_bs(device, device, errp);
 | |
|     if (!bs) {
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     if (!has_writable) {
 | |
|         writable = false;
 | |
|     }
 | |
|     if (bdrv_is_read_only(bs)) {
 | |
|         writable = false;
 | |
|     }
 | |
| 
 | |
|     exp = nbd_export_new(bs, 0, -1, writable ? 0 : NBD_FLAG_READ_ONLY,
 | |
|                          NULL, false, on_eject_blk, errp);
 | |
|     if (!exp) {
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     nbd_export_set_name(exp, device);
 | |
| 
 | |
|     /* The list of named exports has a strong reference to this export now and
 | |
|      * our only way of accessing it is through nbd_export_find(), so we can drop
 | |
|      * the strong reference that is @exp. */
 | |
|     nbd_export_put(exp);
 | |
| }
 | |
| 
 | |
| void qmp_nbd_server_stop(Error **errp)
 | |
| {
 | |
|     nbd_export_close_all();
 | |
| 
 | |
|     nbd_server_free(nbd_server);
 | |
|     nbd_server = NULL;
 | |
| }
 |