The Valgrind tool reports about the uninitialised buffer 'buf' instantiated on the stack of the function guess_disk_lchs(). Pass 'read-zeroes=on' to the null block driver to make it deterministic. The output of the tests 051, 186 and 227 now includes the parameter 'read-zeroes'. So, the benchmark output files are being changed too. Suggested-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
		
			
				
	
	
		
			100 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			100 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
#!/usr/bin/env bash
 | 
						|
#
 | 
						|
# Test query-blockstats with different ways to create a BB
 | 
						|
#
 | 
						|
# Copyright (C) 2018 Red Hat, Inc.
 | 
						|
#
 | 
						|
# This program is free software; you can redistribute it and/or modify
 | 
						|
# it under the terms of the GNU General Public License as published by
 | 
						|
# the Free Software Foundation; either version 2 of the License, or
 | 
						|
# (at your option) any later version.
 | 
						|
#
 | 
						|
# This program is distributed in the hope that it will be useful,
 | 
						|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
# GNU General Public License for more details.
 | 
						|
#
 | 
						|
# You should have received a copy of the GNU General Public License
 | 
						|
# along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | 
						|
#
 | 
						|
 | 
						|
# creator
 | 
						|
owner=kwolf@redhat.com
 | 
						|
 | 
						|
seq=$(basename $0)
 | 
						|
echo "QA output created by $seq"
 | 
						|
 | 
						|
status=1	# failure is the default!
 | 
						|
 | 
						|
_cleanup()
 | 
						|
{
 | 
						|
    _cleanup_test_img
 | 
						|
}
 | 
						|
trap "_cleanup; exit \$status" 0 1 2 3 15
 | 
						|
 | 
						|
# get standard environment, filters and checks
 | 
						|
. ./common.rc
 | 
						|
. ./common.filter
 | 
						|
 | 
						|
_supported_fmt generic
 | 
						|
_supported_proto file
 | 
						|
 | 
						|
do_run_qemu()
 | 
						|
{
 | 
						|
    echo Testing: "$@"
 | 
						|
    $QEMU -nographic -qmp-pretty stdio -serial none "$@"
 | 
						|
    echo
 | 
						|
}
 | 
						|
 | 
						|
run_qemu()
 | 
						|
{
 | 
						|
    do_run_qemu "$@" 2>&1 | _filter_testdir | _filter_qmp \
 | 
						|
                          | _filter_qemu | _filter_imgfmt \
 | 
						|
                          | _filter_generated_node_ids
 | 
						|
}
 | 
						|
 | 
						|
echo
 | 
						|
echo '=== blockstats with -drive if=virtio ==='
 | 
						|
echo
 | 
						|
 | 
						|
run_qemu -drive driver=null-co,read-zeroes=on,if=virtio <<EOF
 | 
						|
{ "execute": "qmp_capabilities" }
 | 
						|
{ "execute": "query-blockstats"}
 | 
						|
{ "execute": "quit" }
 | 
						|
EOF
 | 
						|
 | 
						|
echo
 | 
						|
echo '=== blockstats with -drive if=none ==='
 | 
						|
echo
 | 
						|
 | 
						|
run_qemu -drive driver=null-co,if=none <<EOF
 | 
						|
{ "execute": "qmp_capabilities" }
 | 
						|
{ "execute": "query-blockstats"}
 | 
						|
{ "execute": "quit" }
 | 
						|
EOF
 | 
						|
 | 
						|
echo
 | 
						|
echo '=== blockstats with -blockdev ==='
 | 
						|
echo
 | 
						|
 | 
						|
run_qemu -blockdev driver=null-co,node-name=null <<EOF
 | 
						|
{ "execute": "qmp_capabilities" }
 | 
						|
{ "execute": "query-blockstats"}
 | 
						|
{ "execute": "quit" }
 | 
						|
EOF
 | 
						|
 | 
						|
echo
 | 
						|
echo '=== blockstats with -blockdev and -device ==='
 | 
						|
echo
 | 
						|
 | 
						|
run_qemu -blockdev driver=null-co,read-zeroes=on,node-name=null -device virtio-blk,drive=null,id=virtio0 <<EOF
 | 
						|
{ "execute": "qmp_capabilities" }
 | 
						|
{ "execute": "query-blockstats"}
 | 
						|
{ "execute": "quit" }
 | 
						|
EOF
 | 
						|
 | 
						|
# success, all done
 | 
						|
echo "*** done"
 | 
						|
rm -f $seq.full
 | 
						|
status=0
 |