We were accidently passing RISCVHartArrayState by value instead of pointer. The type is 824 bytes long so let's correct that and pass it by pointer instead. Fixes: Coverity CID 1438099 Fixes: Coverity CID 1438100 Fixes: Coverity CID 1438101 Signed-off-by: Alistair Francis <alistair.francis@wdc.com> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> Reviewed-by: Bin Meng <bin.meng@windriver.com> Message-id: f3e04424723e0e222769991896cc82308fd23f76.1610751609.git.alistair.francis@wdc.com
		
			
				
	
	
		
			56 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			56 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QEMU RISC-V Boot Helper
 | 
						|
 *
 | 
						|
 * Copyright (c) 2017 SiFive, Inc.
 | 
						|
 * Copyright (c) 2019 Alistair Francis <alistair.francis@wdc.com>
 | 
						|
 *
 | 
						|
 * This program is free software; you can redistribute it and/or modify it
 | 
						|
 * under the terms and conditions of the GNU General Public License,
 | 
						|
 * version 2 or later, as published by the Free Software Foundation.
 | 
						|
 *
 | 
						|
 * This program is distributed in the hope it will be useful, but WITHOUT
 | 
						|
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 | 
						|
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 | 
						|
 * more details.
 | 
						|
 *
 | 
						|
 * You should have received a copy of the GNU General Public License along with
 | 
						|
 * this program.  If not, see <http://www.gnu.org/licenses/>.
 | 
						|
 */
 | 
						|
 | 
						|
#ifndef RISCV_BOOT_H
 | 
						|
#define RISCV_BOOT_H
 | 
						|
 | 
						|
#include "exec/cpu-defs.h"
 | 
						|
#include "hw/loader.h"
 | 
						|
#include "hw/riscv/riscv_hart.h"
 | 
						|
 | 
						|
bool riscv_is_32bit(RISCVHartArrayState *harts);
 | 
						|
 | 
						|
target_ulong riscv_calc_kernel_start_addr(RISCVHartArrayState *harts,
 | 
						|
                                          target_ulong firmware_end_addr);
 | 
						|
target_ulong riscv_find_and_load_firmware(MachineState *machine,
 | 
						|
                                          const char *default_machine_firmware,
 | 
						|
                                          hwaddr firmware_load_addr,
 | 
						|
                                          symbol_fn_t sym_cb);
 | 
						|
char *riscv_find_firmware(const char *firmware_filename);
 | 
						|
target_ulong riscv_load_firmware(const char *firmware_filename,
 | 
						|
                                 hwaddr firmware_load_addr,
 | 
						|
                                 symbol_fn_t sym_cb);
 | 
						|
target_ulong riscv_load_kernel(const char *kernel_filename,
 | 
						|
                               target_ulong firmware_end_addr,
 | 
						|
                               symbol_fn_t sym_cb);
 | 
						|
hwaddr riscv_load_initrd(const char *filename, uint64_t mem_size,
 | 
						|
                         uint64_t kernel_entry, hwaddr *start);
 | 
						|
uint32_t riscv_load_fdt(hwaddr dram_start, uint64_t dram_size, void *fdt);
 | 
						|
void riscv_setup_rom_reset_vec(MachineState *machine, RISCVHartArrayState *harts,
 | 
						|
                               hwaddr saddr,
 | 
						|
                               hwaddr rom_base, hwaddr rom_size,
 | 
						|
                               uint64_t kernel_entry,
 | 
						|
                               uint32_t fdt_load_addr, void *fdt);
 | 
						|
void riscv_rom_copy_firmware_info(MachineState *machine, hwaddr rom_base,
 | 
						|
                                  hwaddr rom_size,
 | 
						|
                                  uint32_t reset_vec_size,
 | 
						|
                                  uint64_t kernel_entry);
 | 
						|
 | 
						|
#endif /* RISCV_BOOT_H */
 |