There's no need to force the user to assign a vdev. We can automatically assign one, starting at xvda and searching until we find the first disk name that's unused. This means we can now allow '-drive if=xen,file=xxx' to work without an explicit separate -driver argument, just like if=virtio. Rip out the legacy handling from the xenpv machine, which was scribbling over any disks configured by the toolstack, and didn't work with anything but raw images. Signed-off-by: David Woodhouse <dwmw@amazon.co.uk> Acked-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Paul Durrant <paul@xen.org>
		
			
				
	
	
		
			102 lines
		
	
	
		
			2.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			102 lines
		
	
	
		
			2.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
#include "qemu/osdep.h"
 | 
						|
#include "hw/xen/xen-legacy-backend.h"
 | 
						|
#include "qemu/option.h"
 | 
						|
#include "sysemu/blockdev.h"
 | 
						|
#include "sysemu/sysemu.h"
 | 
						|
 | 
						|
/* ------------------------------------------------------------- */
 | 
						|
 | 
						|
static int xen_config_dev_dirs(const char *ftype, const char *btype, int vdev,
 | 
						|
                               char *fe, char *be, int len)
 | 
						|
{
 | 
						|
    char *dom;
 | 
						|
 | 
						|
    dom = qemu_xen_xs_get_domain_path(xenstore, xen_domid);
 | 
						|
    snprintf(fe, len, "%s/device/%s/%d", dom, ftype, vdev);
 | 
						|
    free(dom);
 | 
						|
 | 
						|
    dom = qemu_xen_xs_get_domain_path(xenstore, 0);
 | 
						|
    snprintf(be, len, "%s/backend/%s/%d/%d", dom, btype, xen_domid, vdev);
 | 
						|
    free(dom);
 | 
						|
 | 
						|
    xenstore_mkdir(fe, XS_PERM_READ | XS_PERM_WRITE);
 | 
						|
    xenstore_mkdir(be, XS_PERM_READ);
 | 
						|
    return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int xen_config_dev_all(char *fe, char *be)
 | 
						|
{
 | 
						|
    /* frontend */
 | 
						|
    if (xen_protocol)
 | 
						|
        xenstore_write_str(fe, "protocol", xen_protocol);
 | 
						|
 | 
						|
    xenstore_write_int(fe, "state",           XenbusStateInitialising);
 | 
						|
    xenstore_write_int(fe, "backend-id",      0);
 | 
						|
    xenstore_write_str(fe, "backend",         be);
 | 
						|
 | 
						|
    /* backend */
 | 
						|
    xenstore_write_str(be, "domain",          qemu_name ? qemu_name : "no-name");
 | 
						|
    xenstore_write_int(be, "online",          1);
 | 
						|
    xenstore_write_int(be, "state",           XenbusStateInitialising);
 | 
						|
    xenstore_write_int(be, "frontend-id",     xen_domid);
 | 
						|
    xenstore_write_str(be, "frontend",        fe);
 | 
						|
 | 
						|
    return 0;
 | 
						|
}
 | 
						|
 | 
						|
/* ------------------------------------------------------------- */
 | 
						|
 | 
						|
int xen_config_dev_nic(NICInfo *nic)
 | 
						|
{
 | 
						|
    char fe[256], be[256];
 | 
						|
    char mac[20];
 | 
						|
    int vlan_id = -1;
 | 
						|
 | 
						|
    net_hub_id_for_client(nic->netdev, &vlan_id);
 | 
						|
    snprintf(mac, sizeof(mac), "%02x:%02x:%02x:%02x:%02x:%02x",
 | 
						|
             nic->macaddr.a[0], nic->macaddr.a[1], nic->macaddr.a[2],
 | 
						|
             nic->macaddr.a[3], nic->macaddr.a[4], nic->macaddr.a[5]);
 | 
						|
    xen_pv_printf(NULL, 1, "config nic %d: mac=\"%s\"\n", vlan_id, mac);
 | 
						|
    xen_config_dev_dirs("vif", "qnic", vlan_id, fe, be, sizeof(fe));
 | 
						|
 | 
						|
    /* frontend */
 | 
						|
    xenstore_write_int(fe, "handle",     vlan_id);
 | 
						|
    xenstore_write_str(fe, "mac",        mac);
 | 
						|
 | 
						|
    /* backend */
 | 
						|
    xenstore_write_int(be, "handle",     vlan_id);
 | 
						|
    xenstore_write_str(be, "mac",        mac);
 | 
						|
 | 
						|
    /* common stuff */
 | 
						|
    return xen_config_dev_all(fe, be);
 | 
						|
}
 | 
						|
 | 
						|
int xen_config_dev_vfb(int vdev, const char *type)
 | 
						|
{
 | 
						|
    char fe[256], be[256];
 | 
						|
 | 
						|
    xen_config_dev_dirs("vfb", "vfb", vdev, fe, be, sizeof(fe));
 | 
						|
 | 
						|
    /* backend */
 | 
						|
    xenstore_write_str(be, "type",  type);
 | 
						|
 | 
						|
    /* common stuff */
 | 
						|
    return xen_config_dev_all(fe, be);
 | 
						|
}
 | 
						|
 | 
						|
int xen_config_dev_vkbd(int vdev)
 | 
						|
{
 | 
						|
    char fe[256], be[256];
 | 
						|
 | 
						|
    xen_config_dev_dirs("vkbd", "vkbd", vdev, fe, be, sizeof(fe));
 | 
						|
    return xen_config_dev_all(fe, be);
 | 
						|
}
 | 
						|
 | 
						|
int xen_config_dev_console(int vdev)
 | 
						|
{
 | 
						|
    char fe[256], be[256];
 | 
						|
 | 
						|
    xen_config_dev_dirs("console", "console", vdev, fe, be, sizeof(fe));
 | 
						|
    return xen_config_dev_all(fe, be);
 | 
						|
}
 |