 9ea057dc64
			
		
	
	
		9ea057dc64
		
	
	
	
	
		
			
			overall, all devices' realize functions take an Error **errp, but return void.
hw/core/qdev.c code, which realizes devices, therefore does:
local_err = NULL;
dc->realize(dev, &local_err);
if (local_err != NULL) {
    goto fail;
}
However, we can improve at least accel_cpu to return a meaningful bool value.
Signed-off-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210322132800.7470-9-cfontana@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
		
	
			
		
			
				
	
	
		
			95 lines
		
	
	
		
			3.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			95 lines
		
	
	
		
			3.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /* QEMU accelerator interfaces
 | |
|  *
 | |
|  * Copyright (c) 2014 Red Hat Inc
 | |
|  *
 | |
|  * Permission is hereby granted, free of charge, to any person obtaining a copy
 | |
|  * of this software and associated documentation files (the "Software"), to deal
 | |
|  * in the Software without restriction, including without limitation the rights
 | |
|  * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 | |
|  * copies of the Software, and to permit persons to whom the Software is
 | |
|  * furnished to do so, subject to the following conditions:
 | |
|  *
 | |
|  * The above copyright notice and this permission notice shall be included in
 | |
|  * all copies or substantial portions of the Software.
 | |
|  *
 | |
|  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 | |
|  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 | |
|  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
 | |
|  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 | |
|  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 | |
|  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 | |
|  * THE SOFTWARE.
 | |
|  */
 | |
| #ifndef QEMU_ACCEL_H
 | |
| #define QEMU_ACCEL_H
 | |
| 
 | |
| #include "qom/object.h"
 | |
| #include "exec/hwaddr.h"
 | |
| 
 | |
| typedef struct AccelState {
 | |
|     /*< private >*/
 | |
|     Object parent_obj;
 | |
| } AccelState;
 | |
| 
 | |
| typedef struct AccelClass {
 | |
|     /*< private >*/
 | |
|     ObjectClass parent_class;
 | |
|     /*< public >*/
 | |
| 
 | |
|     const char *name;
 | |
|     int (*init_machine)(MachineState *ms);
 | |
| #ifndef CONFIG_USER_ONLY
 | |
|     void (*setup_post)(MachineState *ms, AccelState *accel);
 | |
|     bool (*has_memory)(MachineState *ms, AddressSpace *as,
 | |
|                        hwaddr start_addr, hwaddr size);
 | |
| #endif
 | |
|     bool *allowed;
 | |
|     /*
 | |
|      * Array of global properties that would be applied when specific
 | |
|      * accelerator is chosen. It works like MachineClass.compat_props
 | |
|      * but it's for accelerators not machines. Accelerator-provided
 | |
|      * global properties may be overridden by machine-type
 | |
|      * compat_props or user-provided global properties.
 | |
|      */
 | |
|     GPtrArray *compat_props;
 | |
| } AccelClass;
 | |
| 
 | |
| #define TYPE_ACCEL "accel"
 | |
| 
 | |
| #define ACCEL_CLASS_SUFFIX  "-" TYPE_ACCEL
 | |
| #define ACCEL_CLASS_NAME(a) (a ACCEL_CLASS_SUFFIX)
 | |
| 
 | |
| #define ACCEL_CLASS(klass) \
 | |
|     OBJECT_CLASS_CHECK(AccelClass, (klass), TYPE_ACCEL)
 | |
| #define ACCEL(obj) \
 | |
|     OBJECT_CHECK(AccelState, (obj), TYPE_ACCEL)
 | |
| #define ACCEL_GET_CLASS(obj) \
 | |
|     OBJECT_GET_CLASS(AccelClass, (obj), TYPE_ACCEL)
 | |
| 
 | |
| AccelClass *accel_find(const char *opt_name);
 | |
| AccelState *current_accel(void);
 | |
| 
 | |
| void accel_init_interfaces(AccelClass *ac);
 | |
| 
 | |
| #ifndef CONFIG_USER_ONLY
 | |
| int accel_init_machine(AccelState *accel, MachineState *ms);
 | |
| 
 | |
| /* Called just before os_setup_post (ie just before drop OS privs) */
 | |
| void accel_setup_post(MachineState *ms);
 | |
| #endif /* !CONFIG_USER_ONLY */
 | |
| 
 | |
| /**
 | |
|  * accel_cpu_instance_init:
 | |
|  * @cpu: The CPU that needs to do accel-specific object initializations.
 | |
|  */
 | |
| void accel_cpu_instance_init(CPUState *cpu);
 | |
| 
 | |
| /**
 | |
|  * accel_cpu_realizefn:
 | |
|  * @cpu: The CPU that needs to call accel-specific cpu realization.
 | |
|  * @errp: currently unused.
 | |
|  */
 | |
| bool accel_cpu_realizefn(CPUState *cpu, Error **errp);
 | |
| 
 | |
| #endif /* QEMU_ACCEL_H */
 |