There is no point in having mcf_uart_init() demote the DeviceState pointer and return a void one. Directly return the real typedef. mcf_uart_init() do both init + realize: rename as mcf_uart_create(). Similarly, mcf_uart_mm_init() do init / realize / mmap: rename as mcf_uart_create_mmap(). Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-ID: <20231019104929.16517-1-philmd@linaro.org> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
		
			
				
	
	
		
			25 lines
		
	
	
		
			688 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			25 lines
		
	
	
		
			688 B
		
	
	
	
		
			C
		
	
	
	
	
	
#ifndef HW_MCF_H
 | 
						|
#define HW_MCF_H
 | 
						|
/* Motorola ColdFire device prototypes.  */
 | 
						|
 | 
						|
#include "exec/hwaddr.h"
 | 
						|
#include "target/m68k/cpu-qom.h"
 | 
						|
 | 
						|
/* mcf_uart.c */
 | 
						|
uint64_t mcf_uart_read(void *opaque, hwaddr addr,
 | 
						|
                       unsigned size);
 | 
						|
void mcf_uart_write(void *opaque, hwaddr addr,
 | 
						|
                    uint64_t val, unsigned size);
 | 
						|
DeviceState *mcf_uart_create(qemu_irq irq, Chardev *chr);
 | 
						|
DeviceState *mcf_uart_create_mmap(hwaddr base, qemu_irq irq, Chardev *chr);
 | 
						|
 | 
						|
/* mcf_intc.c */
 | 
						|
qemu_irq *mcf_intc_init(struct MemoryRegion *sysmem,
 | 
						|
                        hwaddr base,
 | 
						|
                        M68kCPU *cpu);
 | 
						|
 | 
						|
/* mcf5206.c */
 | 
						|
#define TYPE_MCF5206_MBAR "mcf5206-mbar"
 | 
						|
 | 
						|
#endif
 |