 acd80015fb
			
		
	
	
		acd80015fb
		
	
	
	
	
		
			
			A lot of tests provide code for adding and removing a device via the device_add and device_del QMP commands. Maintaining this code in so many places is cumbersome and error-prone (some of the code parts check the responses for device deletion in an incorrect way, for example, we've got to deal with both, error code and DEVICE_DEL event here). So let's provide some proper generic functions for adding and removing a device instead. The code for correctly unplugging a device has been taken from a patch from Peter Xu. Reviewed-by: Peter Xu <peterx@redhat.com> Tested-by: Peter Xu <peterx@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
		
			
				
	
	
		
			55 lines
		
	
	
		
			1.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			55 lines
		
	
	
		
			1.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * QTest testcase for USB xHCI controller
 | |
|  *
 | |
|  * Copyright (c) 2014 HUAWEI TECHNOLOGIES CO., LTD.
 | |
|  *
 | |
|  * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | |
|  * See the COPYING file in the top-level directory.
 | |
|  */
 | |
| 
 | |
| #include "qemu/osdep.h"
 | |
| #include "libqtest.h"
 | |
| #include "libqos/usb.h"
 | |
| 
 | |
| 
 | |
| static void test_xhci_init(void)
 | |
| {
 | |
| }
 | |
| 
 | |
| static void test_xhci_hotplug(void)
 | |
| {
 | |
|     usb_test_hotplug("xhci", 1, NULL);
 | |
| }
 | |
| 
 | |
| static void test_usb_uas_hotplug(void)
 | |
| {
 | |
|     qtest_qmp_device_add("usb-uas", "uas", NULL);
 | |
|     qtest_qmp_device_add("scsi-hd", "scsihd", "'drive': 'drive0'");
 | |
| 
 | |
|     /* TODO:
 | |
|         UAS HBA driver in libqos, to check that
 | |
|         added disk is visible after BUS rescan
 | |
|     */
 | |
| 
 | |
|     qtest_qmp_device_del("scsihd");
 | |
|     qtest_qmp_device_del("uas");
 | |
| }
 | |
| 
 | |
| int main(int argc, char **argv)
 | |
| {
 | |
|     int ret;
 | |
| 
 | |
|     g_test_init(&argc, &argv, NULL);
 | |
| 
 | |
|     qtest_add_func("/xhci/pci/init", test_xhci_init);
 | |
|     qtest_add_func("/xhci/pci/hotplug", test_xhci_hotplug);
 | |
|     qtest_add_func("/xhci/pci/hotplug/usb-uas", test_usb_uas_hotplug);
 | |
| 
 | |
|     qtest_start("-device nec-usb-xhci,id=xhci"
 | |
|                 " -drive id=drive0,if=none,file=null-co://,format=raw");
 | |
|     ret = g_test_run();
 | |
|     qtest_end();
 | |
| 
 | |
|     return ret;
 | |
| }
 |