 c5bd6d02e6
			
		
	
	
		c5bd6d02e6
		
	
	
	
	
		
			
			VIRTIO Device Initialization requires feature negotiation. The libqos virtio-9p driver lacks feature negotiation and is therefore non-compliant. libqos tests acknowledge all feature bits advertised by the device, except VIRTIO_F_BAD_FEATURE (which devices use to detect broken drivers!) and VIRTIO_RING_F_EVENT_IDX (which is not implemented in libqos and accepting it would break notifications). Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <20191023100425.12168-7-stefanha@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Thomas Huth" <thuth@redhat.com>
		
			
				
	
	
		
			181 lines
		
	
	
		
			5.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			181 lines
		
	
	
		
			5.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * libqos driver framework
 | |
|  *
 | |
|  * Copyright (c) 2018 Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>
 | |
|  *
 | |
|  * This library is free software; you can redistribute it and/or
 | |
|  * modify it under the terms of the GNU Lesser General Public
 | |
|  * License version 2 as published by the Free Software Foundation.
 | |
|  *
 | |
|  * This library is distributed in the hope that it will be useful,
 | |
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 | |
|  * Lesser General Public License for more details.
 | |
|  *
 | |
|  * You should have received a copy of the GNU Lesser General Public
 | |
|  * License along with this library; if not, see <http://www.gnu.org/licenses/>
 | |
|  */
 | |
| 
 | |
| #include "qemu/osdep.h"
 | |
| #include "libqtest.h"
 | |
| #include "qemu/module.h"
 | |
| #include "standard-headers/linux/virtio_ids.h"
 | |
| #include "libqos/virtio-9p.h"
 | |
| #include "libqos/qgraph.h"
 | |
| 
 | |
| static QGuestAllocator *alloc;
 | |
| 
 | |
| static void virtio_9p_cleanup(QVirtio9P *interface)
 | |
| {
 | |
|     qvirtqueue_cleanup(interface->vdev->bus, interface->vq, alloc);
 | |
| }
 | |
| 
 | |
| static void virtio_9p_setup(QVirtio9P *interface)
 | |
| {
 | |
|     uint64_t features;
 | |
| 
 | |
|     features = qvirtio_get_features(interface->vdev);
 | |
|     features &= ~(QVIRTIO_F_BAD_FEATURE | (1ull << VIRTIO_RING_F_EVENT_IDX));
 | |
|     qvirtio_set_features(interface->vdev, features);
 | |
| 
 | |
|     interface->vq = qvirtqueue_setup(interface->vdev, alloc, 0);
 | |
|     qvirtio_set_driver_ok(interface->vdev);
 | |
| }
 | |
| 
 | |
| /* virtio-9p-device */
 | |
| static void virtio_9p_device_destructor(QOSGraphObject *obj)
 | |
| {
 | |
|     QVirtio9PDevice *v_9p = (QVirtio9PDevice *) obj;
 | |
|     QVirtio9P *v9p = &v_9p->v9p;
 | |
| 
 | |
|     virtio_9p_cleanup(v9p);
 | |
| }
 | |
| 
 | |
| static void virtio_9p_device_start_hw(QOSGraphObject *obj)
 | |
| {
 | |
|     QVirtio9PDevice *v_9p = (QVirtio9PDevice *) obj;
 | |
|     QVirtio9P *v9p = &v_9p->v9p;
 | |
| 
 | |
|     virtio_9p_setup(v9p);
 | |
| }
 | |
| 
 | |
| static void *virtio_9p_get_driver(QVirtio9P *v_9p,
 | |
|                                          const char *interface)
 | |
| {
 | |
|     if (!g_strcmp0(interface, "virtio-9p")) {
 | |
|         return v_9p;
 | |
|     }
 | |
|     if (!g_strcmp0(interface, "virtio")) {
 | |
|         return v_9p->vdev;
 | |
|     }
 | |
| 
 | |
|     fprintf(stderr, "%s not present in virtio-9p-device\n", interface);
 | |
|     g_assert_not_reached();
 | |
| }
 | |
| 
 | |
| static void *virtio_9p_device_get_driver(void *object, const char *interface)
 | |
| {
 | |
|     QVirtio9PDevice *v_9p = object;
 | |
|     return virtio_9p_get_driver(&v_9p->v9p, interface);
 | |
| }
 | |
| 
 | |
| static void *virtio_9p_device_create(void *virtio_dev,
 | |
|                                      QGuestAllocator *t_alloc,
 | |
|                                      void *addr)
 | |
| {
 | |
|     QVirtio9PDevice *virtio_device = g_new0(QVirtio9PDevice, 1);
 | |
|     QVirtio9P *interface = &virtio_device->v9p;
 | |
| 
 | |
|     interface->vdev = virtio_dev;
 | |
|     alloc = t_alloc;
 | |
| 
 | |
|     virtio_device->obj.destructor = virtio_9p_device_destructor;
 | |
|     virtio_device->obj.get_driver = virtio_9p_device_get_driver;
 | |
|     virtio_device->obj.start_hw = virtio_9p_device_start_hw;
 | |
| 
 | |
|     return &virtio_device->obj;
 | |
| }
 | |
| 
 | |
| /* virtio-9p-pci */
 | |
| static void virtio_9p_pci_destructor(QOSGraphObject *obj)
 | |
| {
 | |
|     QVirtio9PPCI *v9_pci = (QVirtio9PPCI *) obj;
 | |
|     QVirtio9P *interface = &v9_pci->v9p;
 | |
|     QOSGraphObject *pci_vobj =  &v9_pci->pci_vdev.obj;
 | |
| 
 | |
|     virtio_9p_cleanup(interface);
 | |
|     qvirtio_pci_destructor(pci_vobj);
 | |
| }
 | |
| 
 | |
| static void virtio_9p_pci_start_hw(QOSGraphObject *obj)
 | |
| {
 | |
|     QVirtio9PPCI *v9_pci = (QVirtio9PPCI *) obj;
 | |
|     QVirtio9P *interface = &v9_pci->v9p;
 | |
|     QOSGraphObject *pci_vobj =  &v9_pci->pci_vdev.obj;
 | |
| 
 | |
|     qvirtio_pci_start_hw(pci_vobj);
 | |
|     virtio_9p_setup(interface);
 | |
| }
 | |
| 
 | |
| static void *virtio_9p_pci_get_driver(void *object, const char *interface)
 | |
| {
 | |
|     QVirtio9PPCI *v_9p = object;
 | |
|     if (!g_strcmp0(interface, "pci-device")) {
 | |
|         return v_9p->pci_vdev.pdev;
 | |
|     }
 | |
|     return virtio_9p_get_driver(&v_9p->v9p, interface);
 | |
| }
 | |
| 
 | |
| static void *virtio_9p_pci_create(void *pci_bus, QGuestAllocator *t_alloc,
 | |
|                                   void *addr)
 | |
| {
 | |
|     QVirtio9PPCI *v9_pci = g_new0(QVirtio9PPCI, 1);
 | |
|     QVirtio9P *interface = &v9_pci->v9p;
 | |
|     QOSGraphObject *obj = &v9_pci->pci_vdev.obj;
 | |
| 
 | |
|     virtio_pci_init(&v9_pci->pci_vdev, pci_bus, addr);
 | |
|     interface->vdev = &v9_pci->pci_vdev.vdev;
 | |
|     alloc = t_alloc;
 | |
| 
 | |
|     g_assert_cmphex(interface->vdev->device_type, ==, VIRTIO_ID_9P);
 | |
| 
 | |
|     obj->destructor = virtio_9p_pci_destructor;
 | |
|     obj->start_hw = virtio_9p_pci_start_hw;
 | |
|     obj->get_driver = virtio_9p_pci_get_driver;
 | |
| 
 | |
|     return obj;
 | |
| }
 | |
| 
 | |
| static void virtio_9p_register_nodes(void)
 | |
| {
 | |
|     const char *str_simple = "fsdev=fsdev0,mount_tag=" MOUNT_TAG;
 | |
|     const char *str_addr = "fsdev=fsdev0,addr=04.0,mount_tag=" MOUNT_TAG;
 | |
| 
 | |
|     QPCIAddress addr = {
 | |
|         .devfn = QPCI_DEVFN(4, 0),
 | |
|     };
 | |
| 
 | |
|     QOSGraphEdgeOptions opts = {
 | |
|         .before_cmd_line = "-fsdev synth,id=fsdev0",
 | |
|     };
 | |
| 
 | |
|     /* virtio-9p-device */
 | |
|     opts.extra_device_opts = str_simple,
 | |
|     qos_node_create_driver("virtio-9p-device", virtio_9p_device_create);
 | |
|     qos_node_consumes("virtio-9p-device", "virtio-bus", &opts);
 | |
|     qos_node_produces("virtio-9p-device", "virtio");
 | |
|     qos_node_produces("virtio-9p-device", "virtio-9p");
 | |
| 
 | |
|     /* virtio-9p-pci */
 | |
|     opts.extra_device_opts = str_addr;
 | |
|     add_qpci_address(&opts, &addr);
 | |
|     qos_node_create_driver("virtio-9p-pci", virtio_9p_pci_create);
 | |
|     qos_node_consumes("virtio-9p-pci", "pci-bus", &opts);
 | |
|     qos_node_produces("virtio-9p-pci", "pci-device");
 | |
|     qos_node_produces("virtio-9p-pci", "virtio");
 | |
|     qos_node_produces("virtio-9p-pci", "virtio-9p");
 | |
| 
 | |
| }
 | |
| 
 | |
| libqos_init(virtio_9p_register_nodes);
 |