The change removes some unnecessary and incorrect code for EXTR_S.H. Further, it corrects the mask for shift value in the EXTR_ instructions. It also extends the existing tests so they trigger the issues corrected with the change. Signed-off-by: Petar Jovanovic <petarj@mips.com> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
		
			
				
	
	
		
			72 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			72 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
#include<stdio.h>
 | 
						|
#include<assert.h>
 | 
						|
 | 
						|
int main()
 | 
						|
{
 | 
						|
    int rt, ach, acl, dsp;
 | 
						|
    int result;
 | 
						|
 | 
						|
    ach = 0x05;
 | 
						|
    acl = 0xB4CB;
 | 
						|
    result = 0x7FFFFFFF;
 | 
						|
    __asm
 | 
						|
        ("mthi %2, $ac1\n\t"
 | 
						|
         "mtlo %3, $ac1\n\t"
 | 
						|
         "extr_rs.w %0, $ac1, 0x03\n\t"
 | 
						|
         "rddsp %1\n\t"
 | 
						|
         : "=r"(rt), "=r"(dsp)
 | 
						|
         : "r"(ach), "r"(acl)
 | 
						|
        );
 | 
						|
    dsp = (dsp >> 23) & 0x01;
 | 
						|
    assert(dsp == 1);
 | 
						|
    assert(result == rt);
 | 
						|
 | 
						|
    /* Clear dspcontrol */
 | 
						|
    dsp = 0;
 | 
						|
    __asm
 | 
						|
        ("wrdsp %0\n\t"
 | 
						|
         :
 | 
						|
         : "r"(dsp)
 | 
						|
        );
 | 
						|
 | 
						|
    ach = 0x01;
 | 
						|
    acl = 0xB4CB;
 | 
						|
    result = 0x10000B4D;
 | 
						|
    __asm
 | 
						|
        ("mthi %2, $ac1\n\t"
 | 
						|
         "mtlo %3, $ac1\n\t"
 | 
						|
         "extr_rs.w %0, $ac1, 0x04\n\t"
 | 
						|
         "rddsp %1\n\t"
 | 
						|
         : "=r"(rt), "=r"(dsp)
 | 
						|
         : "r"(ach), "r"(acl)
 | 
						|
        );
 | 
						|
    dsp = (dsp >> 23) & 0x01;
 | 
						|
    assert(dsp == 0);
 | 
						|
    assert(result == rt);
 | 
						|
 | 
						|
    /* Clear dspcontrol */
 | 
						|
    dsp = 0;
 | 
						|
    __asm
 | 
						|
        ("wrdsp %0\n\t"
 | 
						|
         :
 | 
						|
         : "r"(dsp)
 | 
						|
        );
 | 
						|
 | 
						|
    ach = 0x3fffffff;
 | 
						|
    acl = 0x2bcdef01;
 | 
						|
    result = 0x7ffffffe;
 | 
						|
    __asm
 | 
						|
        ("mthi %2, $ac1\n\t"
 | 
						|
         "mtlo %3, $ac1\n\t"
 | 
						|
         "extr_rs.w %0, $ac1, 0x1F\n\t"
 | 
						|
         "rddsp %1\n\t"
 | 
						|
         : "=r"(rt), "=r"(dsp)
 | 
						|
         : "r"(ach), "r"(acl)
 | 
						|
        );
 | 
						|
    dsp = (dsp >> 23) & 0x01;
 | 
						|
    assert(dsp == 0);
 | 
						|
    assert(result == rt);
 | 
						|
 | 
						|
    return 0;
 | 
						|
}
 |