Currently, the generated function body will do "strlen(arg)" but the argument could be 'char **' or 'char * const *'. Avoid that by excluding such cases in is_string check. Reported by patchew's "make docker-test-mingw@fedora". Suggested-by: Eric Blake <eblake@redhat.com> Signed-off-by: Fam Zheng <famz@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-id: 1477453806-21097-1-git-send-email-famz@redhat.com Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
		
			
				
	
	
		
			109 lines
		
	
	
		
			2.9 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			109 lines
		
	
	
		
			2.9 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
#!/usr/bin/env python
 | 
						|
# -*- coding: utf-8 -*-
 | 
						|
 | 
						|
"""
 | 
						|
Simple built-in backend.
 | 
						|
"""
 | 
						|
 | 
						|
__author__     = "Lluís Vilanova <vilanova@ac.upc.edu>"
 | 
						|
__copyright__  = "Copyright 2012-2014, Lluís Vilanova <vilanova@ac.upc.edu>"
 | 
						|
__license__    = "GPL version 2 or (at your option) any later version"
 | 
						|
 | 
						|
__maintainer__ = "Stefan Hajnoczi"
 | 
						|
__email__      = "stefanha@linux.vnet.ibm.com"
 | 
						|
 | 
						|
 | 
						|
from tracetool import out
 | 
						|
 | 
						|
 | 
						|
PUBLIC = True
 | 
						|
 | 
						|
 | 
						|
def is_string(arg):
 | 
						|
    strtype = ('const char*', 'char*', 'const char *', 'char *')
 | 
						|
    arg_strip = arg.lstrip()
 | 
						|
    if arg_strip.startswith(strtype) and arg_strip.count('*') == 1:
 | 
						|
        return True
 | 
						|
    else:
 | 
						|
        return False
 | 
						|
 | 
						|
 | 
						|
def generate_h_begin(events, group):
 | 
						|
    for event in events:
 | 
						|
        out('void _simple_%(api)s(%(args)s);',
 | 
						|
            api=event.api(),
 | 
						|
            args=event.args)
 | 
						|
    out('')
 | 
						|
 | 
						|
 | 
						|
def generate_h(event, group):
 | 
						|
    out('        _simple_%(api)s(%(args)s);',
 | 
						|
        api=event.api(),
 | 
						|
        args=", ".join(event.args.names()))
 | 
						|
 | 
						|
 | 
						|
def generate_c_begin(events, group):
 | 
						|
    out('#include "qemu/osdep.h"',
 | 
						|
        '#include "trace.h"',
 | 
						|
        '#include "trace/control.h"',
 | 
						|
        '#include "trace/simple.h"',
 | 
						|
        '')
 | 
						|
 | 
						|
 | 
						|
def generate_c(event, group):
 | 
						|
    out('void _simple_%(api)s(%(args)s)',
 | 
						|
        '{',
 | 
						|
        '    TraceBufferRecord rec;',
 | 
						|
        api=event.api(),
 | 
						|
        args=event.args)
 | 
						|
    sizes = []
 | 
						|
    for type_, name in event.args:
 | 
						|
        if is_string(type_):
 | 
						|
            out('    size_t arg%(name)s_len = %(name)s ? MIN(strlen(%(name)s), MAX_TRACE_STRLEN) : 0;',
 | 
						|
                name=name)
 | 
						|
            strsizeinfo = "4 + arg%s_len" % name
 | 
						|
            sizes.append(strsizeinfo)
 | 
						|
        else:
 | 
						|
            sizes.append("8")
 | 
						|
    sizestr = " + ".join(sizes)
 | 
						|
    if len(event.args) == 0:
 | 
						|
        sizestr = '0'
 | 
						|
 | 
						|
    event_id = 'TRACE_' + event.name.upper()
 | 
						|
    if "vcpu" in event.properties:
 | 
						|
        # already checked on the generic format code
 | 
						|
        cond = "true"
 | 
						|
    else:
 | 
						|
        cond = "trace_event_get_state(%s)" % event_id
 | 
						|
 | 
						|
    out('',
 | 
						|
        '    if (!%(cond)s) {',
 | 
						|
        '        return;',
 | 
						|
        '    }',
 | 
						|
        '',
 | 
						|
        '    if (trace_record_start(&rec, %(event_obj)s.id, %(size_str)s)) {',
 | 
						|
        '        return; /* Trace Buffer Full, Event Dropped ! */',
 | 
						|
        '    }',
 | 
						|
        cond=cond,
 | 
						|
        event_obj=event.api(event.QEMU_EVENT),
 | 
						|
        size_str=sizestr)
 | 
						|
 | 
						|
    if len(event.args) > 0:
 | 
						|
        for type_, name in event.args:
 | 
						|
            # string
 | 
						|
            if is_string(type_):
 | 
						|
                out('    trace_record_write_str(&rec, %(name)s, arg%(name)s_len);',
 | 
						|
                    name=name)
 | 
						|
            # pointer var (not string)
 | 
						|
            elif type_.endswith('*'):
 | 
						|
                out('    trace_record_write_u64(&rec, (uintptr_t)(uint64_t *)%(name)s);',
 | 
						|
                    name=name)
 | 
						|
            # primitive data type
 | 
						|
            else:
 | 
						|
                out('    trace_record_write_u64(&rec, (uint64_t)%(name)s);',
 | 
						|
                   name=name)
 | 
						|
 | 
						|
    out('    trace_record_finish(&rec);',
 | 
						|
        '}',
 | 
						|
        '')
 |