When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away.  Convert
    if (!foo(..., &err)) {
        ...
        error_propagate(errp, err);
        ...
        return ...
    }
to
    if (!foo(..., errp)) {
        ...
        ...
        return ...
    }
where nothing else needs @err.  Coccinelle script:
    @rule1 forall@
    identifier fun, err, errp, lbl;
    expression list args, args2;
    binary operator op;
    constant c1, c2;
    symbol false;
    @@
         if (
    (
    -        fun(args, &err, args2)
    +        fun(args, errp, args2)
    |
    -        !fun(args, &err, args2)
    +        !fun(args, errp, args2)
    |
    -        fun(args, &err, args2) op c1
    +        fun(args, errp, args2) op c1
    )
            )
         {
             ... when != err
                 when != lbl:
                 when strict
    -        error_propagate(errp, err);
             ... when != err
    (
             return;
    |
             return c2;
    |
             return false;
    )
         }
    @rule2 forall@
    identifier fun, err, errp, lbl;
    expression list args, args2;
    expression var;
    binary operator op;
    constant c1, c2;
    symbol false;
    @@
    -    var = fun(args, &err, args2);
    +    var = fun(args, errp, args2);
         ... when != err
         if (
    (
             var
    |
             !var
    |
             var op c1
    )
            )
         {
             ... when != err
                 when != lbl:
                 when strict
    -        error_propagate(errp, err);
             ... when != err
    (
             return;
    |
             return c2;
    |
             return false;
    |
             return var;
    )
         }
    @depends on rule1 || rule2@
    identifier err;
    @@
    -    Error *err = NULL;
         ... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
         if (fun(args, &err)) {
             goto out
         }
         ...
     out:
         error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly.  I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err".  For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there.  Converted manually.
Line breaks tidied up manually.  One nested declaration of @local_err
deleted manually.  Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
		
	
			
		
			
				
	
	
		
			209 lines
		
	
	
		
			5.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			209 lines
		
	
	
		
			5.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QEMU Host Memory Backend for hugetlbfs
 | 
						|
 *
 | 
						|
 * Copyright (C) 2013-2014 Red Hat Inc
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *   Paolo Bonzini <pbonzini@redhat.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | 
						|
 * See the COPYING file in the top-level directory.
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "qapi/error.h"
 | 
						|
#include "qemu/error-report.h"
 | 
						|
#include "qemu/module.h"
 | 
						|
#include "sysemu/hostmem.h"
 | 
						|
#include "sysemu/sysemu.h"
 | 
						|
#include "qom/object_interfaces.h"
 | 
						|
 | 
						|
#define MEMORY_BACKEND_FILE(obj) \
 | 
						|
    OBJECT_CHECK(HostMemoryBackendFile, (obj), TYPE_MEMORY_BACKEND_FILE)
 | 
						|
 | 
						|
typedef struct HostMemoryBackendFile HostMemoryBackendFile;
 | 
						|
 | 
						|
struct HostMemoryBackendFile {
 | 
						|
    HostMemoryBackend parent_obj;
 | 
						|
 | 
						|
    char *mem_path;
 | 
						|
    uint64_t align;
 | 
						|
    bool discard_data;
 | 
						|
    bool is_pmem;
 | 
						|
};
 | 
						|
 | 
						|
static void
 | 
						|
file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
 | 
						|
{
 | 
						|
#ifndef CONFIG_POSIX
 | 
						|
    error_setg(errp, "backend '%s' not supported on this host",
 | 
						|
               object_get_typename(OBJECT(backend)));
 | 
						|
#else
 | 
						|
    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(backend);
 | 
						|
    gchar *name;
 | 
						|
 | 
						|
    if (!backend->size) {
 | 
						|
        error_setg(errp, "can't create backend with size 0");
 | 
						|
        return;
 | 
						|
    }
 | 
						|
    if (!fb->mem_path) {
 | 
						|
        error_setg(errp, "mem-path property not set");
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    name = host_memory_backend_get_name(backend);
 | 
						|
    memory_region_init_ram_from_file(&backend->mr, OBJECT(backend),
 | 
						|
                                     name,
 | 
						|
                                     backend->size, fb->align,
 | 
						|
                                     (backend->share ? RAM_SHARED : 0) |
 | 
						|
                                     (fb->is_pmem ? RAM_PMEM : 0),
 | 
						|
                                     fb->mem_path, errp);
 | 
						|
    g_free(name);
 | 
						|
#endif
 | 
						|
}
 | 
						|
 | 
						|
static char *get_mem_path(Object *o, Error **errp)
 | 
						|
{
 | 
						|
    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
 | 
						|
 | 
						|
    return g_strdup(fb->mem_path);
 | 
						|
}
 | 
						|
 | 
						|
static void set_mem_path(Object *o, const char *str, Error **errp)
 | 
						|
{
 | 
						|
    HostMemoryBackend *backend = MEMORY_BACKEND(o);
 | 
						|
    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
 | 
						|
 | 
						|
    if (host_memory_backend_mr_inited(backend)) {
 | 
						|
        error_setg(errp, "cannot change property 'mem-path' of %s",
 | 
						|
                   object_get_typename(o));
 | 
						|
        return;
 | 
						|
    }
 | 
						|
    g_free(fb->mem_path);
 | 
						|
    fb->mem_path = g_strdup(str);
 | 
						|
}
 | 
						|
 | 
						|
static bool file_memory_backend_get_discard_data(Object *o, Error **errp)
 | 
						|
{
 | 
						|
    return MEMORY_BACKEND_FILE(o)->discard_data;
 | 
						|
}
 | 
						|
 | 
						|
static void file_memory_backend_set_discard_data(Object *o, bool value,
 | 
						|
                                               Error **errp)
 | 
						|
{
 | 
						|
    MEMORY_BACKEND_FILE(o)->discard_data = value;
 | 
						|
}
 | 
						|
 | 
						|
static void file_memory_backend_get_align(Object *o, Visitor *v,
 | 
						|
                                          const char *name, void *opaque,
 | 
						|
                                          Error **errp)
 | 
						|
{
 | 
						|
    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
 | 
						|
    uint64_t val = fb->align;
 | 
						|
 | 
						|
    visit_type_size(v, name, &val, errp);
 | 
						|
}
 | 
						|
 | 
						|
static void file_memory_backend_set_align(Object *o, Visitor *v,
 | 
						|
                                          const char *name, void *opaque,
 | 
						|
                                          Error **errp)
 | 
						|
{
 | 
						|
    HostMemoryBackend *backend = MEMORY_BACKEND(o);
 | 
						|
    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
 | 
						|
    uint64_t val;
 | 
						|
 | 
						|
    if (host_memory_backend_mr_inited(backend)) {
 | 
						|
        error_setg(errp, "cannot change property '%s' of %s", name,
 | 
						|
                   object_get_typename(o));
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    if (!visit_type_size(v, name, &val, errp)) {
 | 
						|
        return;
 | 
						|
    }
 | 
						|
    fb->align = val;
 | 
						|
}
 | 
						|
 | 
						|
static bool file_memory_backend_get_pmem(Object *o, Error **errp)
 | 
						|
{
 | 
						|
    return MEMORY_BACKEND_FILE(o)->is_pmem;
 | 
						|
}
 | 
						|
 | 
						|
static void file_memory_backend_set_pmem(Object *o, bool value, Error **errp)
 | 
						|
{
 | 
						|
    HostMemoryBackend *backend = MEMORY_BACKEND(o);
 | 
						|
    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
 | 
						|
 | 
						|
    if (host_memory_backend_mr_inited(backend)) {
 | 
						|
        error_setg(errp, "cannot change property 'pmem' of %s.",
 | 
						|
                   object_get_typename(o));
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
#ifndef CONFIG_LIBPMEM
 | 
						|
    if (value) {
 | 
						|
        error_setg(errp, "Lack of libpmem support while setting the 'pmem=on'"
 | 
						|
                   " of %s. We can't ensure data persistence.",
 | 
						|
                   object_get_typename(o));
 | 
						|
        return;
 | 
						|
    }
 | 
						|
#endif
 | 
						|
 | 
						|
    fb->is_pmem = value;
 | 
						|
}
 | 
						|
 | 
						|
static void file_backend_unparent(Object *obj)
 | 
						|
{
 | 
						|
    HostMemoryBackend *backend = MEMORY_BACKEND(obj);
 | 
						|
    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(obj);
 | 
						|
 | 
						|
    if (host_memory_backend_mr_inited(backend) && fb->discard_data) {
 | 
						|
        void *ptr = memory_region_get_ram_ptr(&backend->mr);
 | 
						|
        uint64_t sz = memory_region_size(&backend->mr);
 | 
						|
 | 
						|
        qemu_madvise(ptr, sz, QEMU_MADV_REMOVE);
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
static void
 | 
						|
file_backend_class_init(ObjectClass *oc, void *data)
 | 
						|
{
 | 
						|
    HostMemoryBackendClass *bc = MEMORY_BACKEND_CLASS(oc);
 | 
						|
 | 
						|
    bc->alloc = file_backend_memory_alloc;
 | 
						|
    oc->unparent = file_backend_unparent;
 | 
						|
 | 
						|
    object_class_property_add_bool(oc, "discard-data",
 | 
						|
        file_memory_backend_get_discard_data, file_memory_backend_set_discard_data);
 | 
						|
    object_class_property_add_str(oc, "mem-path",
 | 
						|
        get_mem_path, set_mem_path);
 | 
						|
    object_class_property_add(oc, "align", "int",
 | 
						|
        file_memory_backend_get_align,
 | 
						|
        file_memory_backend_set_align,
 | 
						|
        NULL, NULL);
 | 
						|
    object_class_property_add_bool(oc, "pmem",
 | 
						|
        file_memory_backend_get_pmem, file_memory_backend_set_pmem);
 | 
						|
}
 | 
						|
 | 
						|
static void file_backend_instance_finalize(Object *o)
 | 
						|
{
 | 
						|
    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
 | 
						|
 | 
						|
    g_free(fb->mem_path);
 | 
						|
}
 | 
						|
 | 
						|
static const TypeInfo file_backend_info = {
 | 
						|
    .name = TYPE_MEMORY_BACKEND_FILE,
 | 
						|
    .parent = TYPE_MEMORY_BACKEND,
 | 
						|
    .class_init = file_backend_class_init,
 | 
						|
    .instance_finalize = file_backend_instance_finalize,
 | 
						|
    .instance_size = sizeof(HostMemoryBackendFile),
 | 
						|
};
 | 
						|
 | 
						|
static void register_types(void)
 | 
						|
{
 | 
						|
    type_register_static(&file_backend_info);
 | 
						|
}
 | 
						|
 | 
						|
type_init(register_types);
 |