SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

target/ppc/mmu_common.c: Init variable in function that relies on it

Browse Source 
The ppc6xx_tlb_check() relies on the caller to initialise raddr field
in ctx. Move this init from the only caller into the function.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
This commit is contained in:
BALATON Zoltan 2024-05-27 01:12:56 +02:00 committed by Nicholas Piggin
parent 620ba617df
commit fa7f2cb91b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
target/ppc/mmu_common.c
View File

@ -102,6 +102,8 @@ static int ppc6xx_tlb_check(CPUPPCState *env,
int nr, best, way, ret; int nr, best, way, ret;
bool is_code = (access_type == MMU_INST_FETCH); bool is_code = (access_type == MMU_INST_FETCH);
/* Initialize real address with an invalid value */
ctx->raddr = (hwaddr)-1ULL;
best = -1; best = -1;
ret = -1; /* No TLB found */ ret = -1; /* No TLB found */
for (way = 0; way < env->nb_ways; way++) { for (way = 0; way < env->nb_ways; way++) {
@ -340,8 +342,6 @@ static int mmu6xx_get_physical_address(CPUPPCState *env, mmu_ctx_t *ctx,
ppc_hash32_hpt_base(cpu), ppc_hash32_hpt_mask(cpu), hash); ppc_hash32_hpt_base(cpu), ppc_hash32_hpt_mask(cpu), hash);
*hashp = hash; *hashp = hash;
/* Initialize real address with an invalid value */
ctx->raddr = (hwaddr)-1ULL;
/* Software TLB search */ /* Software TLB search */
return ppc6xx_tlb_check(env, ctx, eaddr, access_type, ptem, nx); return ppc6xx_tlb_check(env, ctx, eaddr, access_type, ptem, nx);
} }