SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hw/char/pl011: Simplify a bit pl011_can_receive()

Browse Source 
Introduce 'fifo_depth' and 'fifo_available' local variables
to better express the 'r' variable use.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Luc Michel <luc.michel@amd.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20250220092903.3726-3-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2025-02-19 15:35:53 +01:00
parent abf2b6a028
commit f33af61dba
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hw/char/pl011.c
View File

@ -486,7 +486,9 @@ static void pl011_write(void *opaque, hwaddr offset,
static int pl011_can_receive(void *opaque) static int pl011_can_receive(void *opaque)
{ {
PL011State *s = (PL011State *)opaque; PL011State *s = (PL011State *)opaque;
int r; unsigned fifo_depth = pl011_get_fifo_depth(s);
unsigned fifo_available = fifo_depth - s->read_count;
int r = fifo_available ? 1 : 0;
if (!(s->cr & CR_UARTEN)) { if (!(s->cr & CR_UARTEN)) {
qemu_log_mask(LOG_GUEST_ERROR, qemu_log_mask(LOG_GUEST_ERROR,
@ -496,7 +498,6 @@ static int pl011_can_receive(void *opaque)
qemu_log_mask(LOG_GUEST_ERROR, qemu_log_mask(LOG_GUEST_ERROR,
"PL011 receiving data on disabled RX UART\n"); "PL011 receiving data on disabled RX UART\n");
} }
r = s->read_count < pl011_get_fifo_depth(s);
trace_pl011_can_receive(s->lcr, s->read_count, r); trace_pl011_can_receive(s->lcr, s->read_count, r);
return r; return r;
} }