SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hw/arm/spitz: Use LOG_GUEST_ERROR for bad guest register accesses

Browse Source 
Instead of logging guest accesses to invalid register offsets in the
Spitz flash device with zaurus_printf() (which just prints to stderr),
use the usual qemu_log_mask(LOG_GUEST_ERROR,...).

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200628142429.17111-15-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2020-07-03 16:59:45 +01:00
parent a0a8cf78e0
commit eb2d6dbc98
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hw/arm/spitz.c
View File

@ -23,6 +23,7 @@
#include "hw/ssi/ssi.h" #include "hw/ssi/ssi.h"
#include "hw/block/flash.h" #include "hw/block/flash.h"
#include "qemu/timer.h" #include "qemu/timer.h"
#include "qemu/log.h"
#include "hw/arm/sharpsl.h" #include "hw/arm/sharpsl.h"
#include "ui/console.h" #include "ui/console.h"
#include "hw/audio/wm8750.h" #include "hw/audio/wm8750.h"
@ -65,9 +66,6 @@ typedef struct {
#define zaurus_printf(format, ...) \ #define zaurus_printf(format, ...) \
fprintf(stderr, "%s: " format, __func__, ##__VA_ARGS__) fprintf(stderr, "%s: " format, __func__, ##__VA_ARGS__)
#undef REG_FMT
#define REG_FMT "0x%02lx"
/* Spitz Flash */ /* Spitz Flash */
#define FLASH_BASE 0x0c000000 #define FLASH_BASE 0x0c000000
#define FLASH_ECCLPLB 0x00 /* Line parity 7 - 0 bit */ #define FLASH_ECCLPLB 0x00 /* Line parity 7 - 0 bit */
@ -137,7 +135,9 @@ static uint64_t sl_read(void *opaque, hwaddr addr, unsigned size)
return ecc_digest(&s->ecc, nand_getio(s->nand)); return ecc_digest(&s->ecc, nand_getio(s->nand));
default: default:
zaurus_printf("Bad register offset " REG_FMT "\n", (unsigned long)addr); qemu_log_mask(LOG_GUEST_ERROR,
"sl_read: bad register offset 0x%02" HWADDR_PRIx "\n",
addr);
} }
return 0; return 0;
} }
@ -168,7 +168,9 @@ static void sl_write(void *opaque, hwaddr addr,
break; break;
default: default:
zaurus_printf("Bad register offset " REG_FMT "\n", (unsigned long)addr); qemu_log_mask(LOG_GUEST_ERROR,
"sl_write: bad register offset 0x%02" HWADDR_PRIx "\n",
addr);
} }
} }