SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hw/pvrdma: Fix zero-initialization of resp in {query/modify}_qp

Browse Source 
Make sure to zero-initialize only the pvrdma_cmd_query_qp_resp and not
the whole pvrdma_cmd_resp for query_qp, in modify_qp the resp isn't used
so remove it.

Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Message-Id: <20190314153031.7197-5-kamalheib1@gmail.com>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
This commit is contained in:
Kamal Heib 2019-03-14 17:30:31 +02:00 committed by Marcel Apfelbaum
parent a421c81148
commit d151f5debd
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/rdma/vmw/pvrdma_cmd.c
View File

@ -488,8 +488,6 @@ static int modify_qp(PVRDMADev *dev, union pvrdma_cmd_req *req,
struct pvrdma_cmd_modify_qp *cmd = &req->modify_qp; struct pvrdma_cmd_modify_qp *cmd = &req->modify_qp;
int rc; int rc;
memset(rsp, 0, sizeof(*rsp));
/* No need to verify sgid_index since it is u8 */ /* No need to verify sgid_index since it is u8 */
rc = rdma_rm_modify_qp(&dev->rdma_dev_res, &dev->backend_dev, rc = rdma_rm_modify_qp(&dev->rdma_dev_res, &dev->backend_dev,
@ -512,7 +510,7 @@ static int query_qp(PVRDMADev *dev, union pvrdma_cmd_req *req,
struct ibv_qp_init_attr init_attr; struct ibv_qp_init_attr init_attr;
int rc; int rc;
memset(rsp, 0, sizeof(*rsp)); memset(resp, 0, sizeof(*resp));
rc = rdma_rm_query_qp(&dev->rdma_dev_res, &dev->backend_dev, cmd->qp_handle, rc = rdma_rm_query_qp(&dev->rdma_dev_res, &dev->backend_dev, cmd->qp_handle,
(struct ibv_qp_attr *)&resp->attrs, cmd->attr_mask, (struct ibv_qp_attr *)&resp->attrs, cmd->attr_mask,