SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests/device-introspection: Check that the qom-tree and qtree do not change

Browse Source 
Introspection should not change the qom-tree / qtree, so we should check
this in the device-introspect-test, too. This patch helped to find lots
of instrospection bugs during the QEMU v3.0 soft/hard-freeze period in the
last two months.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1534419358-10932-7-git-send-email-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Thomas Huth 2018-08-16 13:35:56 +02:00 committed by Paolo Bonzini
parent 1f4a0d81af
commit d068521264
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tests/device-introspect-test.c
View File

@ -103,7 +103,14 @@ static QList *device_type_list(bool abstract)
static void test_one_device(const char *type) static void test_one_device(const char *type)
{ {
QDict *resp; QDict *resp;
char *help, *qom_tree; char *help;
char *qom_tree_start, *qom_tree_end;
char *qtree_start, *qtree_end;
g_test_message("Testing device '%s'", type);
qom_tree_start = hmp("info qom-tree");
qtree_start = hmp("info qtree");
resp = qmp("{'execute': 'device-list-properties'," resp = qmp("{'execute': 'device-list-properties',"
" 'arguments': {'typename': %s}}", " 'arguments': {'typename': %s}}",
@ -115,10 +122,18 @@ static void test_one_device(const char *type)
/* /*
* Some devices leave dangling pointers in QOM behind. * Some devices leave dangling pointers in QOM behind.
* "info qom-tree" has a good chance at crashing then * "info qom-tree" or "info qtree" have a good chance at crashing then.
* Also make sure that the tree did not change.
*/ */
qom_tree = hmp("info qom-tree"); qom_tree_end = hmp("info qom-tree");
g_free(qom_tree); g_assert_cmpstr(qom_tree_start, ==, qom_tree_end);
g_free(qom_tree_start);
g_free(qom_tree_end);
qtree_end = hmp("info qtree");
g_assert_cmpstr(qtree_start, ==, qtree_end);
g_free(qtree_start);
g_free(qtree_end);
} }
static void test_device_intro_list(void) static void test_device_intro_list(void)