SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

vfio: Rephrase comment in vfio_listener_region_add() error path

Browse Source 
Rephrase a bit the ending comment about how errors are handled
depending on the phase in which vfio_listener_region_add() is called.

Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20250206131438.1505542-4-clg@redhat.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
This commit is contained in:
Cédric Le Goater 2025-02-06 14:14:31 +01:00
parent cbfbedd617
commit cdc6f2e0c9
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
hw/vfio/common.c
View File

@ -683,12 +683,13 @@ fail:
error_reportf_err(err, "PCI p2p may not work: "); error_reportf_err(err, "PCI p2p may not work: ");
return; return;
} }
/*
* On the initfn path, store the first error in the container so we
* can gracefully fail. Runtime, there's not much we can do other
* than throw a hardware error.
*/
if (!bcontainer->initialized) { if (!bcontainer->initialized) {
/*
* At machine init time or when the device is attached to the
* VM, store the first error in the container so we can
* gracefully fail the device realize routine.
*/
if (!bcontainer->error) { if (!bcontainer->error) {
error_propagate_prepend(&bcontainer->error, err, error_propagate_prepend(&bcontainer->error, err,
"Region %s: ", "Region %s: ",
@ -697,6 +698,10 @@ fail:
error_free(err); error_free(err);
} }
} else { } else {
/*
* At runtime, there's not much we can do other than throw a
* hardware error.
*/
error_report_err(err); error_report_err(err);
hw_error("vfio: DMA mapping failed, unable to continue"); hw_error("vfio: DMA mapping failed, unable to continue");
} }