SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hw/smbios: Fix OEM strings table option validation

Browse Source 
qemu_smbios_type11_opts did not have the list terminator and that
resulted in out-of-bound memory access. It also needs to have an element
for the type option.

Cc: qemu-stable@nongnu.org
Fixes: 2d6dcbf93fb0 ("smbios: support setting OEM strings table")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
Akihiko Odaki 2024-01-29 17:03:07 +09:00 committed by Michael Tokarev
parent 9953bf34ee
commit cd8a35b913
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/smbios/smbios.c
View File

@ -375,6 +375,11 @@ static const QemuOptDesc qemu_smbios_type8_opts[] = {
}; };
static const QemuOptDesc qemu_smbios_type11_opts[] = { static const QemuOptDesc qemu_smbios_type11_opts[] = {
{
.name = "type",
.type = QEMU_OPT_NUMBER,
.help = "SMBIOS element type",
},
{ {
.name = "value", .name = "value",
.type = QEMU_OPT_STRING, .type = QEMU_OPT_STRING,
@ -385,6 +390,7 @@ static const QemuOptDesc qemu_smbios_type11_opts[] = {
.type = QEMU_OPT_STRING, .type = QEMU_OPT_STRING,
.help = "OEM string data from file", .help = "OEM string data from file",
}, },
{ /* end of list */ }
}; };
static const QemuOptDesc qemu_smbios_type17_opts[] = { static const QemuOptDesc qemu_smbios_type17_opts[] = {