SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

i386/sev: fix unreachable code coverity issue

Browse Source 
Set 'finish->id_block_en' early, so that it is properly reset.

Fixes coverity CID 1546887.

Fixes: 7b34df4426 ("i386/sev: Introduce 'sev-snp-guest' object")
Signed-off-by: Pankaj Gupta <pankaj.gupta@amd.com>
Message-ID: <20240607183611.1111100-2-pankaj.gupta@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Pankaj Gupta 2024-06-07 13:36:09 -05:00 committed by Paolo Bonzini
parent 903916f0a0
commit c94eb5db8e
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
target/i386/sev.c
View File

@ -2165,6 +2165,7 @@ sev_snp_guest_set_id_block(Object *obj, const char *value, Error **errp)
struct kvm_sev_snp_launch_finish *finish = &sev_snp_guest->kvm_finish_conf; struct kvm_sev_snp_launch_finish *finish = &sev_snp_guest->kvm_finish_conf;
gsize len; gsize len;
finish->id_block_en = 0;
g_free(sev_snp_guest->id_block); g_free(sev_snp_guest->id_block);
g_free((guchar *)finish->id_block_uaddr); g_free((guchar *)finish->id_block_uaddr);
@ -2184,7 +2185,7 @@ sev_snp_guest_set_id_block(Object *obj, const char *value, Error **errp)
return; return;
} }
finish->id_block_en = (len) ? 1 : 0; finish->id_block_en = 1;
} }
static char * static char *