SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests/unit/test-smp-parse: Split the 'generic' test in valid / invalid

Browse Source 
Split the 'generic' test in two tests: 'valid' and 'invalid'.
This will allow us to remove the hack which modifies the
MachineClass internal state.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211216132015.815493-3-philmd@redhat.com>
This commit is contained in:
Philippe Mathieu-Daudé 2021-11-15 12:35:43 +01:00
parent 1ab192f30c
commit c30bdb025c
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/unit/test-smp-parse.c
View File

@ -487,7 +487,7 @@ static void machine_base_class_init(ObjectClass *oc, void *data)
mc->name = g_strdup(SMP_MACHINE_NAME); mc->name = g_strdup(SMP_MACHINE_NAME);
} }
static void test_generic(const void *opaque) static void test_generic_valid(const void *opaque)
{ {
const char *machine_type = opaque; const char *machine_type = opaque;
Object *obj = object_new(machine_type); Object *obj = object_new(machine_type);
@ -508,6 +508,18 @@ static void test_generic(const void *opaque)
smp_parse_test(ms, data, true); smp_parse_test(ms, data, true);
} }
object_unref(obj);
}
static void test_generic_invalid(const void *opaque)
{
const char *machine_type = opaque;
Object *obj = object_new(machine_type);
MachineState *ms = MACHINE(obj);
MachineClass *mc = MACHINE_GET_CLASS(obj);
SMPTestData *data = &(SMPTestData){};
int i;
/* Force invalid min CPUs and max CPUs */ /* Force invalid min CPUs and max CPUs */
mc->min_cpus = 2; mc->min_cpus = 2;
mc->max_cpus = 511; mc->max_cpus = 511;
@ -601,9 +613,12 @@ int main(int argc, char *argv[])
g_test_init(&argc, &argv, NULL); g_test_init(&argc, &argv, NULL);
g_test_add_data_func("/test-smp-parse/generic", g_test_add_data_func("/test-smp-parse/generic/valid",
TYPE_MACHINE, TYPE_MACHINE,
test_generic); test_generic_valid);
g_test_add_data_func("/test-smp-parse/generic/invalid",
TYPE_MACHINE,
test_generic_invalid);
g_test_add_data_func("/test-smp-parse/with_dies", g_test_add_data_func("/test-smp-parse/with_dies",
TYPE_MACHINE, TYPE_MACHINE,
test_with_dies); test_with_dies);