SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hw/block/nvme: fix uint16_t use of uint32_t sgls member

Browse Source 
nvme_map_sgl_data erroneously uses the sgls member of NvmeIdNs as a
uint16_t.

Reported-by: Coverity (CID 1436129)
Fixes: cba0a8a344fe ("hw/block/nvme: add support for scatter gather lists")
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Message-Id: <20201104102248.32168-3-its@irrelevant.dk>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
This commit is contained in:
Klaus Jensen 2020-11-04 11:22:47 +01:00 committed by Max Reitz
parent 8ce648056f
commit bf288953f1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/block/nvme.c
View File

@ -452,7 +452,7 @@ static uint16_t nvme_map_sgl_data(NvmeCtrl *n, QEMUSGList *qsg,
* segments and/or descriptors. The controller might accept * segments and/or descriptors. The controller might accept
* ignoring the rest of the SGL. * ignoring the rest of the SGL.
*/ */
uint16_t sgls = le16_to_cpu(n->id_ctrl.sgls); uint32_t sgls = le32_to_cpu(n->id_ctrl.sgls);
if (sgls & NVME_CTRL_SGLS_EXCESS_LENGTH) { if (sgls & NVME_CTRL_SGLS_EXCESS_LENGTH) {
break; break;
} }